Skip to content

add seekbar_control_keyboard #25140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

add seekbar_control_keyboard #25140

wants to merge 19 commits into from
+111 −0

Conversation

sotarokashiuchi
Copy link

Description

Add support for seekbar_control_keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Apr 12, 2025
View reviewed changes
keyboards/seekbar_control_keyboard/config.h Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed, all these options migrated to keyboard.json.

keyboards/seekbar_control_keyboard/rules.mk Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These options need to be migrated to keyboard.json, and this file removed.

@waffle87 waffle87 added the pr_checklist_pending Needs changes as per the PR checklist label Apr 12, 2025
dunk2k
dunk2k suggested changes Apr 12, 2025
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Device Version
  2. Community Layout support added

@sotarokashiuchi
Copy link
Author

Hi!
Thank you for the review!
I've applied your suggestions.

I also tried migrating the settings from config.h and rules.mk to keyboard.json as best as I could.
Could you please check if the changes look correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 Awaiting requested review from waffle87

Assignees
No one assigned
Labels
keyboard keymap pr_checklist_pending Needs changes as per the PR checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotarokashiuchi @waffle87 @dunk2k