Skip to content

Rookiebwoy to ivndbt #25142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Rookiebwoy to ivndbt #25142

wants to merge 10 commits into from

Conversation

ivndbt
Copy link
Contributor

@ivndbt ivndbt commented Apr 13, 2025

Rename keyboard folder 'rookiebwoy' to 'ivndbt' and update internal identifiers.

Description

This pull request renames the keyboard folder from rookiebwoy to ivndbt to reflect the user's GitHub account name change.

Additionally, the following internal changes have been made within the keyboard definitions:

  • Updated comments in the files to reflect the new name.
  • Modified the OLED graphics for the late9 keyboard.
  • Updated the Product ID (PID) and Vendor ID (VID) for the neopad keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A (This is primarily a renaming and minor update, not directly fixing an existing issue)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ivndbt
Copy link
Contributor Author

ivndbt commented Apr 13, 2025

Lint check not passed because the file data/mapping/keyboard_aliases.hjson still refers to old folder. Should I update it manually or it's autogenerated?

@zvecr zvecr changed the base branch from master to develop April 13, 2025 15:07
@zvecr zvecr added the invalid label Apr 13, 2025
@zvecr
Copy link
Member

zvecr commented Apr 13, 2025

From the PR checklist:

  • keyboard moves within the repository must go through the develop branch instead of master, so as to ensure compatibility for users
    • data/mappings/keyboard_aliases.hjson must be updated to reflect the move, so users with pre-created configurator keymap.json files continue to detect the correct keyboard

Also the changes to lib/ must be reverted for us to be able to accept this PR.

@github-actions github-actions bot added the dd Data Driven Changes label Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dd Data Driven Changes keyboard keymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants