-
-
Notifications
You must be signed in to change notification settings - Fork 41.4k
Addition of the Ymdk Oni HHKB pcb #25162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the release 1 of this keyboard.
Removing the uppercase R1 folder
I don't know why the |
Please close this PR and continue work on the original one. The submodule versions of the branch you're trying to merge probably have diverged from upstream QMK. You can try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the addition of all LED PCBs with per-key RGB and underglow using the Matrix driver. The board had already been submitted in the past (#21004) but wasn't accepted at the time due to uncertainty related to its naming. I've linked the official website, and upon receiving the board, before reflashing it with my firmware, the board was recognized as ONI_HHKB on VIA desktop.
Happy to make any further changes as required.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist