Skip to content

Addition of the Ymdk Oni HHKB pcb #25162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

Conversation

ChrisGVE
Copy link
Contributor

This is the addition of all LED PCBs with per-key RGB and underglow using the Matrix driver. The board had already been submitted in the past (#21004) but wasn't accepted at the time due to uncertainty related to its naming. I've linked the official website, and upon receiving the board, before reflashing it with my firmware, the board was recognized as ONI_HHKB on VIA desktop.

Happy to make any further changes as required.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ChrisGVE
Copy link
Contributor Author

I don't know why the chibios/chibios-contrib have been changed, as I did not make the changes myself. How can I resolve that?

@waffle87
Copy link
Member

Please close this PR and continue work on the original one. The submodule versions of the branch you're trying to merge probably have diverged from upstream QMK. You can try qmk git-submodule.

@ChrisGVE ChrisGVE closed this May 3, 2025
@ChrisGVE ChrisGVE deleted the ymdk_oni_hhkb branch May 3, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants