[Keyboard] Add lesieber/zer0pad#26118
Open
lesieber wants to merge 3 commits intoqmk:masterfrom
Open
Conversation
A 3x3 ortholinear macropad using Pro Micro with 4 layers and VIA support. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
keyboard
keymap
via
4 tasks
drashna
requested changes
Mar 30, 2026
Comment on lines
+26
to
+39
| void eeconfig_init_user(void) { | ||
| // Initialize default layer names in EEPROM | ||
| const char* defaults[] = {"Base", "Numbers", "Functions", "Media"}; | ||
| for (int i = 0; i < 4; i++) { | ||
| strncpy(layer_names[i], defaults[i], 15); | ||
| layer_names[i][15] = '\0'; | ||
| } | ||
| eeconfig_update_user_datablock(layer_names); | ||
| } | ||
|
|
||
| void keyboard_post_init_user(void) { | ||
| // Load layer names from EEPROM | ||
| eeconfig_read_user_datablock(layer_names); | ||
| } |
Member
There was a problem hiding this comment.
These should be kb functions, not user functions.
| #define DYNAMIC_KEYMAP_LAYER_COUNT 4 | ||
|
|
||
| // EEPROM for storing layer names (16 chars per layer x 4 layers = 64 bytes) | ||
| #define EECONFIG_USER_DATA_SIZE 64 |
Member
There was a problem hiding this comment.
Suggested change
| #define EECONFIG_USER_DATA_SIZE 64 | |
| #define EECONFIG_KB_DATA_SIZE 64 |
or
Suggested change
| #define EECONFIG_USER_DATA_SIZE 64 |
Comment on lines
+40
to
+42
| "dynamic_keymap": { | ||
| "layer_count": 4 | ||
| }, |
Member
There was a problem hiding this comment.
Suggested change
| "dynamic_keymap": { | |
| "layer_count": 4 | |
| }, |
| "bootmagic": true, | ||
| "extrakey": true, | ||
| "mousekey": true, | ||
| "nkro": false, |
Member
There was a problem hiding this comment.
Suggested change
| "nkro": false, |
| } | ||
|
|
||
| // Called when layer state changes | ||
| layer_state_t layer_state_set_user(layer_state_t state) { |
| } | ||
|
|
||
| // Handle raw HID commands from companion app / web configurator | ||
| void raw_hid_receive(uint8_t *data, uint8_t length) { |
Member
There was a problem hiding this comment.
Just a heads up, this will likely error out when VIA is enabled.
- Remove VIA keymap from qmk_firmware submission\n- Simplify default keymap to pristine single-layer layout\n- Drop redundant/default config entries\n- Remove custom keyboard code that conflicted with review guidance\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Thanks for the review — I've pushed the requested changes. Addressed in this update:
VIA content is handled separately in the VIA repo PR: |
Remove effectively empty config.h and rules.mk so qmk lint --strict no longer fails for lesieber/zer0pad. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
zvecr
removed
invalid
via
drashna
reviewed
Apr 23, 2026
Member
drashna
left a comment
drashna
left a comment
There was a problem hiding this comment.
If you set the dev board, it sets a number of things, including the controller, and bootloader. And makes it easier for converter support.
| "cols": ["D1", "D0", "D4"], | ||
| "rows": ["C6", "D7", "E6"] | ||
| }, | ||
| "processor": "atmega32u4", |
Member
There was a problem hiding this comment.
Suggested change
| "processor": "atmega32u4", |
| "manufacturer": "Leon Sieber", | ||
| "keyboard_name": "Zer0Pad", | ||
| "maintainer": "lesieber", | ||
| "bootloader": "caterina", |
Member
There was a problem hiding this comment.
Suggested change
| "bootloader": "caterina", | |
| "development_board": "promicro", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding support for the Zer0Pad, a 3x3 ortholinear macropad designed by Leon Sieber.
Types of Changes
Keyboard Information
Features
Checklist