Fix config.h bool parsing#26166
Open
zvecr wants to merge 1 commit intoqmk:masterfrom
Open
Conversation
drashna
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #26163 has
#define NKRO_DEFAULT_ON truewithin a config.h.Running
qmk info -f json -kb owlab/link65/hotswapincorrectly produces:qmk_firmware/lib/python/qmk/info.py
Line 660 in ccc6c6c
At the point the conversion is handled, the config_value is a string of value
"true". This is not within the currently expected true values so returns false.Also updated variable name as it is a constant.
Types of Changes
Issues Fixed or Closed by This PR
Checklist