Apply rustfmt #123
Merged
Apply rustfmt #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly improve code formatting in a few places, and protect all blocks that we don't want rustfmt to change by adding #[rustfmt::skip] attributes where relevant. This is in preparation for running rustfmt on the whole repository. Signed-off-by: Quentin Monnet <[email protected]>
Signed-off-by: Quentin Monnet <[email protected]>
Let's fix formatting using rustfmt, at last.
$ rustfmt --version
rustfmt 1.8.0-nightly (50aa041807 2025-05-08)
$ rustfmt **/**.rs
Signed-off-by: Quentin Monnet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time I've been reluctant to use rustfmt on the sources, because of sections that I didn't want to be reformatted: some alignments in the lists of instructions in the interpreter, or the byte arrays for BPF programs, and so on.
This PR marks all relevant sections as ignored by rustfmt, improves some of the formatting (and addresses Clippy reports) in preparation for rustfmt, and at last, apply rustfmt to the Rust source files.
This makes formatting consistent at last throughout the code base, and can be later enforced in CI - although there's no immediate plan for that. It will also make it easier to contributors who run rustfmt on save by default in their IDE.