Skip to content

fix verifier panic and interpreter overflow #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qmonnet merged 2 commits into from
Jan 15, 2026
Merged

fix verifier panic and interpreter overflow #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
763b582
fix verifier panic and interpreter overflow
Echo8377 Jan 14, 2026
c1de210
Fix: address review comments
Echo8377 Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/interpreter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,8 @@ pub fn execute_program(
check_mem_store(x as u64, 8, insn_ptr)?;
x.write_unaligned(reg[_src]);
},
ebpf::ST_W_XADD => unimplemented!(),
ebpf::ST_DW_XADD => unimplemented!(),
ebpf::ST_W_XADD => Err(Error::other(format!("Error: XADD instructions are not supported (insn #{})", insn_ptr - 1)))?,
ebpf::ST_DW_XADD => Err(Error::other(format!("Error: XADD instructions are not supported (insn #{})", insn_ptr - 1)))?,

// BPF_ALU class
// TODO Check how overflow works in kernel. Should we &= U32MAX all src register value
Expand Down Expand Up @@ -439,7 +439,7 @@ pub fn execute_program(
}
}
}
ebpf::TAIL_CALL => unimplemented!(),
ebpf::TAIL_CALL => Err(Error::other(format!("Error: TAIL_CALL is not supported (insn #{})", insn_ptr - 1)))?,
ebpf::EXIT => {
if stack_frame_idx > 0 {
stack_frame_idx -= 1;
Expand Down
6 changes: 3 additions & 3 deletions src/verifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ pub fn check(prog: &[u8]) -> Result<(), Error> {
ebpf::ST_H_REG => store = true,
ebpf::ST_W_REG => store = true,
ebpf::ST_DW_REG => store = true,
ebpf::ST_W_XADD => { unimplemented!(); },
ebpf::ST_DW_XADD => { unimplemented!(); },
ebpf::ST_W_XADD => { reject(format!("XADD instructions are not supported (insn #{insn_ptr:?})"))?; },
ebpf::ST_DW_XADD => { reject(format!("XADD instructions are not supported (insn #{insn_ptr:?})"))?; },

// BPF_ALU class
ebpf::ADD32_IMM => {},
Expand Down Expand Up @@ -275,7 +275,7 @@ pub fn check(prog: &[u8]) -> Result<(), Error> {
_ => { reject(format!("unsupported call type #{src:?} (insn #{insn_ptr:?})"))?; }
}
},
ebpf::TAIL_CALL => { unimplemented!() },
ebpf::TAIL_CALL => { reject(format!("TAIL_CALL is not supported (insn #{insn_ptr:?})"))?; },
ebpf::EXIT => {},

_ => {
Expand Down
Loading