fix: use is_reg for devisor in emit_muldivmod#140
Merged
Conversation
qmonnet
requested changes
Feb 5, 2026
Owner
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
Thanks for this!
The change looks good. This code was initially derived from uBPF, but there was indeed an issue: iovisor/ubpf#448 and Alan addressed it in iovisor/ubpf#449.
Can you please sign-off your commit?
Signed-off-by: hsqStephenZhang <stephenzhang666666@gmail.com>
hsqStephenZhang
force-pushed
the
fix/jit_div
branch
from
5fedfcb to
5526506
Compare
Contributor
Author
|
Done. |
Contributor
Author
|
Hi, would you mind publishing a new patch version? |
Owner
|
Sure, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should not use
ins.imm != 0to decide if it's a register operationsee: https://github.com/iovisor/ubpf/blob/d8af62f3a5f720d74a1d84ce6b94b86fb7c7cb10/vm/ubpf_jit_x86_64.c#L1299