Skip to content

Add new tool for scanning repository discussions and generating best … #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

mrT23
Copy link
Collaborator

@mrT23 mrT23 commented Apr 16, 2025

User description

…practices


PR Type

Enhancement, Documentation


Description

  • Introduced a new tool /scan_repo_discussions for generating best practices.

  • Updated documentation to include details about the new tool.

  • Enhanced the README and other docs with updated tool descriptions and images.

  • Adjusted configuration and navigation settings for the new tool integration.


Changes walkthrough 📝

Relevant files
Documentation
README.md
Added `/scan_repo_discussions` tool announcement and details

README.md

  • Added announcement for the new /scan_repo_discussions tool.
  • Updated image and link for the new tool documentation.
  • Adjusted formatting and tool descriptions in the overview table.
  • +48/-48 
    index.md
    Updated tools index with `/scan_repo_discussions`               

    docs/docs/index.md

  • Added /scan_repo_discussions tool to the tools list.
  • Updated tool descriptions to include the new feature.
  • +1/-0     
    index.md
    Included `/scan_repo_discussions` in tools overview           

    docs/docs/tools/index.md

  • Added /scan_repo_discussions tool to the tools list.
  • Provided a brief description of the tool's functionality.
  • +1/-0     
    scan_repo_discussions.md
    Added detailed documentation for `/scan_repo_discussions`

    docs/docs/tools/scan_repo_discussions.md

  • Created a new documentation page for /scan_repo_discussions.
  • Detailed tool usage, configuration options, and examples.
  • Included images to illustrate the tool's output and process.
  • +38/-0   
    Configuration changes
    mkdocs.yml
    Updated navigation and theme for `/scan_repo_discussions`

    docs/mkdocs.yml

  • Added /scan_repo_discussions to the navigation menu.
  • Adjusted theme settings and commented out unused features.
  • +4/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Incorrect Link

    The link for the "Scan Repo Discussions" tool points to the implement.md file instead of scan_repo_discussions.md

    | **💎 [Scan Reop Discussions (`/scan_repo_discussions`](./implement.md))**                | Generates `best_practices.md` file based on previous discussions in the repository |
    Note that the tools marked with 💎 are available only for Qodo Merge users.
    Typo

    There's a typo in "Scan Reop Discussions" - should be "Scan Repo Discussions"

    | **💎 [Scan Reop Discussions (`/scan_repo_discussions`](./implement.md))**                | Generates `best_practices.md` file based on previous discussions in the repository |
    Note that the tools marked with 💎 are available only for Qodo Merge users.

    Copy link
    Contributor

    qodo-merge-pro-for-open-source bot commented Apr 16, 2025

    PR Code Suggestions ✨

    Latest suggestions up to a5cb0e4

    CategorySuggestion                                                                                                                                    Impact
    General
    Restore search plugin functionality

    The search plugin is commented out, which will disable search functionality on
    the documentation site. This is inconsistent with having search-related features
    in the theme configuration. Either uncomment the search plugin or remove the
    search-related configurations completely.

    docs/mkdocs.yml [109-112]

     plugins:
       - social
    -#  - search
    +  - search
       - glightbox
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion identifies an important inconsistency where search-related features are commented out in the theme configuration while the search plugin itself is also commented out. Restoring the search plugin is important for documentation site functionality.

    Medium
    Remove duplicate configuration entry
    Suggestion Impact:The commit removed the duplicate 'content.tabs.link' entry from the configuration list, exactly as suggested

    code diff:

    -    - content.tabs.link

    The content.tabs.link feature is duplicated in the list. Remove the duplicate
    entry to avoid potential configuration issues.

    docs/mkdocs.yml [82-86]

     #    - search.suggest
     #    - search.highlight
     - content.tabs.link
     - content.code.annotation
     - content.code.copy
    -- content.tabs.link

    [To ensure code accuracy, apply this suggestion manually]

    Suggestion importance[1-10]: 7

    __

    Why: The suggestion correctly identifies a duplicate entry for 'content.tabs.link' in the configuration list. Removing the duplicate improves code quality and prevents potential configuration issues.

    Medium
    • Update

    Previous suggestions

    ✅ Suggestions up to commit 7704379
    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Fix incorrect documentation link
    Suggestion Impact:The commit fixed the documentation link for the Scan Repo Discussions tool, changing it from './implement.md' to './scan_repo_discussions.md' as suggested

    code diff:

    -| **💎 [Scan Reop Discussions (`/scan_repo_discussions`](./implement.md))**                | Generates `best_practices.md` file based on previous discussions in the repository |
    +| **💎 [Scan Repo Discussions (`/scan_repo_discussions`](./scan_repo_discussions.md))**    | Generates `best_practices.md` file based on previous discussions in the repository |

    The link to the documentation for the Scan Repo Discussions tool points to the
    implementation tool page (./implement.md) instead of the correct
    scan_repo_discussions.md page. This will lead users to the wrong documentation.

    docs/docs/tools/index.md [22]

    -| **💎 [Scan Reop Discussions (`/scan_repo_discussions`](./implement.md))**                | Generates `best_practices.md` file based on previous discussions in the repository |
    +| **💎 [Scan Repo Discussions (`/scan_repo_discussions`](./scan_repo_discussions.md))**                | Generates `best_practices.md` file based on previous discussions in the repository |

    [Suggestion has been applied]

    Suggestion importance[1-10]: 9

    __

    Why: The link to the Scan Repo Discussions tool documentation incorrectly points to "implement.md" instead of "scan_repo_discussions.md". This is a critical navigation issue that would lead users to the wrong documentation page, affecting usability.

    High
    Learned
    best practice
    Include error handling information for configuration parameters to prevent runtime errors when invalid values are provided

    The configuration options don't include any validation or error handling
    guidance. It's important to mention what happens if users provide invalid values
    (like negative numbers or non-numeric input) for the configuration parameters.
    Add information about input validation and error handling to prevent runtime
    errors.

    docs/docs/tools/scan_repo_discussions.md [37-38]

    -- Use `/scan_repo_discussions --scan_repo_discussions.days_back=X` to specify the number of days back to scan for discussions. The default is 365 days.
    -- Use `/scan_repo_discussions --scan_repo_discussions.minimal_number_of_prs=X` to specify the minimum number of merged PRs needed to generate the `best_practices.md` file. The default is 50 PRs.
    +- Use `/scan_repo_discussions --scan_repo_discussions.days_back=X` to specify the number of days back to scan for discussions. The default is 365 days. If a negative or non-numeric value is provided, the default will be used.
    +- Use `/scan_repo_discussions --scan_repo_discussions.minimal_number_of_prs=X` to specify the minimum number of merged PRs needed to generate the `best_practices.md` file. The default is 50 PRs. If a negative or non-numeric value is provided, the default will be used.
    Suggestion importance[1-10]: 6
    Low

    @mrT23 mrT23 merged commit c332a88 into main Apr 16, 2025
    2 checks passed
    @mrT23 mrT23 deleted the tr/scan_repo_discussions_docs branch April 16, 2025 10:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant