Skip to content

fix: restore Dynaconf fresh vars support #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: restore Dynaconf fresh vars support #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1764be1
test: add unit tests to demonstrate Dynaconf fresh vars behavior
pdecat Nov 14, 2025
4f5e1f7
fix: compare keys as uppercase to restore Dynaconf fresh_vars support
pdecat Nov 14, 2025
979bc67
test: remove ensure_file_timestamp_changes, tests pass without it
pdecat Nov 15, 2025
d3878ef
test: only set fresh vars via FRESH_VARS_FOR_DYNACONF as that's the o…
pdecat Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pr_agent/custom_merge_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ def load(obj, env=None, silent=True, key=None, filename=None):
- Replaces list and dict fields instead of appending/updating (non-default Dynaconf behavior).
- Enforces several security checks (e.g., disallows includes/preloads and enforces .toml files).
- Supports optional single-key loading.
- Supports Dynaconf's fresh_vars feature for dynamic reloading.
Args:
obj: The Dynaconf settings instance to update.
env: The current environment name (upper case). Defaults to 'DEVELOPMENT'. Note: currently unused.
Expand Down Expand Up @@ -93,7 +94,8 @@ def load(obj, env=None, silent=True, key=None, filename=None):

# Update the settings object
for k, v in accumulated_data.items():
if key is None or key == k:
# For fresh_vars support: key parameter is uppercase, but accumulated_data keys are lowercase
if key is None or key.upper() == k.upper():
obj.set(k, v)

def validate_file_security(file_data, filename):
Expand Down
Loading