Allow Docker base image override

[evanscastonguay]

User description

Summary

• Add BASE_IMAGE build-arg to Dockerfile
• Document custom base image usage in GitLab installation guide

Testing

• Unable to run docker build locally (Docker daemon not running)

---

PR Type

Enhancement, Documentation

---

Description

• Add BASE_IMAGE build argument to Dockerfile for custom base image override

• Document custom base image usage in GitLab installation guide

• Fix trailing newline in documentation file

---

Diagram Walkthrough

flowchart LR
  A["Dockerfile"] -->|"Add ARG BASE_IMAGE"| B["Parameterized base image"]
  C["GitLab docs"] -->|"Add usage example"| D["Custom registry support"]
  B --> D

Loading

File Walkthrough

	Relevant files
Enhancement	Dockerfile Parameterize Docker base image with build argument              docker/Dockerfile Add ARG BASE_IMAGE=python:3.12.10-slim argument at the beginning Replace hardcoded FROM python:3.12.10-slim with FROM ${BASE_IMAGE} Enables users to override base image during build time +2/-1
Documentation	gitlab.md Document custom base image build argument usage                    docs/docs/installation/gitlab.md Add new section documenting custom base image usage Include example docker build command with --build-arg BASE_IMAGE parameter Fix trailing newline at end of file +8/-1

---

[qodo-free-for-open-source-projects]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
⚪	Arbitrary base image injection Description: The BASE_IMAGE build argument allows arbitrary Docker images to be used as the base, potentially introducing malicious code, vulnerabilities, or incompatible dependencies that could compromise the application's security and functionality. Dockerfile [1-2] Referred Code ARG BASE_IMAGE=python:3.12.10-slim FROM ${BASE_IMAGE} AS base
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Consistent Naming Conventions Objective: All new variables, functions, and classes must follow the project's established naming standards Status: Passed
	No Dead or Commented-Out Code Objective: Keep the codebase clean by ensuring all submitted code is active and necessary Status: Passed
	Single Responsibility for Functions Objective: Each function should have a single, well-defined responsibility Status: Passed
	When relevant, utilize early return Objective: In a code snippet containing multiple logic conditions (such as 'if-else'), prefer an early return on edge cases than deep nesting Status: Passed
⚪	Robust Error Handling Objective: Ensure potential errors and edge cases are anticipated and handled gracefully throughout the code Status: No base image validation: The BASE_IMAGE argument allows arbitrary base images without validation, which could lead to build failures or runtime issues if an incompatible image is provided. Referred Code ARG BASE_IMAGE=python:3.12.10-slim FROM ${BASE_IMAGE} AS base
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-free-for-open-source-projects]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Improve clarity of documentation example To improve clarity, update the documentation example for building with a custom base image to use a placeholder representing an internal registry instead of the default image. docs/docs/installation/gitlab.md [82-87] To build from a custom base image (e.g., an internal registry mirror), pass `BASE_IMAGE`: ```bash -docker build --build-arg BASE_IMAGE=python:3.12.10-slim \ +docker build --build-arg BASE_IMAGE=my.internal.registry/path/to/python:3.12.10-slim \ -t gitlab_pr_agent --target gitlab_webhook -f docker/Dockerfile - [ ] **Apply / Chat** <!-- /improve --apply_suggestion=0 --> <details><summary>Suggestion importance[1-10]: 5</summary> __ Why: The suggestion correctly identifies that the documentation example is confusing by using the default image. The proposed change makes the example clearer and more illustrative of the feature's intended use with an internal registry. </details></details></td><td align=center>Low </td></tr> <tr><td align="center" colspan="2"> - [ ] Update <!-- /improve_multi --more_suggestions=true --> </td><td></td></tr></tbody></table> - [ ] **Author self-review**: I have reviewed the PR code suggestions, and addressed the relevant ones. <!-- fold suggestions self-review -->

[evanscastonguay]

Added BASE_IMAGE validation in Dockerfile (checks for apt-get + python) and documented requirements in gitlab install docs.

[evanscastonguay]

/review

[qodo-free-for-open-source-projects]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

✅ No TODO sections

🔒 No security concerns identified

⚡ Recommended focus areas for review Validation Logic The validation checks for apt-get and python run after the base image is already used. If validation fails, the build will fail at this stage rather than at image selection. Consider if this is the intended behavior or if earlier validation would be more appropriate. RUN if ! command -v apt-get >/dev/null 2>&1; then echo "BASE_IMAGE must provide apt-get (Debian/Ubuntu base)"; exit 1; fi \ && if ! command -v python >/dev/null 2>&1; then echo "BASE_IMAGE must include python"; exit 1; fi Error Handling The validation script uses shell commands that may behave differently across base images. The command -v check might not be universally reliable, and error messages could be more descriptive about which requirement failed. RUN if ! command -v apt-get >/dev/null 2>&1; then echo "BASE_IMAGE must provide apt-get (Debian/Ubuntu base)"; exit 1; fi \ && if ! command -v python >/dev/null 2>&1; then echo "BASE_IMAGE must include python"; exit 1; fi

[naorpeled]

I think it's worth aligning with the example above 🙏

Suggested change

	```bash
	docker build --build-arg BASE_IMAGE=python:3.12.10-slim \
	-t gitlab_pr_agent --target gitlab_webhook -f docker/Dockerfile
	```
	```bash
	docker build . --build-arg BASE_IMAGE=python:3.12.10-slim \
	-t gitlab_pr_agent --target gitlab_webhook -f docker/Dockerfile

[naorpeled]

Let's also add this note to all the other relevant providers

[naorpeled]

Hey @evanscastonguay,
thanks for the great contribution 🔥

Overall LGTM, after my comments are addressed I'll gladly approve and merge this