-
Notifications
You must be signed in to change notification settings - Fork 487
Feature-333: Add code formatters #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature-333: Add code formatters #337
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||||
915e0c0 to
e5a77f2
Compare
e5a77f2 to
ef10932
Compare
|
@andsimakov Looks good. Two requests:
The idea is to have CI run as many Makefile commands as possible so we can have consistency between our local environment and CI. |
5989417 to
9676957
Compare
9676957 to
e55b517
Compare
1051ebd to
51719f0
Compare
51719f0 to
be9a5b2
Compare
| - name: Run E2E Docker tests | ||
| env: | ||
| OPENAI_API_KEY: "This_is_a_fake_API_key" | ||
| OPENAI_API_KEY: ${{ env.FAKE_OPENAI_API_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andsimakov where do you specify this env var?
PR Type
Enhancement, Documentation
Description
Add code formatters Black and isort with configuration.
pyproject.tomlwith formatter dependencies and settings..editorconfigfor consistent editor behavior..pre-commit-config.yamlfor pre-commit integration.Integrate formatting checks into CI pipeline.
Provide documentation for pre-commit hook usage.
docs/pre_commit_hook.mdwith setup and usage instructions.Changes walkthrough 📝
.editorconfig
Add .editorconfig for consistent editor settings.editorconfig
ci_pipeline.yml
Add Black and isort checks to CI pipeline.github/workflows/ci_pipeline.yml
.pre-commit-config.yaml
Add pre-commit config for code formatters.pre-commit-config.yaml
pyproject.toml
Add formatter dependencies and configurationpyproject.toml
pre_commit_hook.md
Document pre-commit hook usage and setupdocs/pre_commit_hook.md