forked from qodo-benchmark/prefect
-
Notifications
You must be signed in to change notification settings - Fork 0
Add UISettings model for /ui-settings endpoint
#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomerqodo
wants to merge
3
commits into
qodo_only-issues-20260113-qodo-grep-copilot_base_add_uisettings_model_for__ui-settings_endpoint_pr283
Choose a base branch
from
qodo_only-issues-20260113-qodo-grep-copilot_head_add_uisettings_model_for__ui-settings_endpoint_pr283
base: qodo_only-issues-20260113-qodo-grep-copilot_base_add_uisettings_model_for__ui-settings_endpoint_pr283
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+104
−10
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,26 @@ | ||
| import json | ||
|
|
||
| from prefect.server.api.server import create_api_app | ||
| from prefect.server.api.server import create_api_app, create_ui_app | ||
|
|
||
| app = create_api_app() | ||
| openapi_schema = app.openapi() | ||
| # Generate schema from main API app | ||
| api_app = create_api_app() | ||
| openapi_schema = api_app.openapi() | ||
|
|
||
| # Generate schema from UI app and merge relevant routes | ||
| ui_app = create_ui_app(ephemeral=True) | ||
| ui_schema = ui_app.openapi() | ||
|
|
||
| # Merge /ui-settings path from ui_app into main schema | ||
| for path, path_item in ui_schema.get("paths", {}).items(): | ||
| if "ui-settings" in path: | ||
| # Use the path without any base URL prefix | ||
| openapi_schema["paths"][path] = path_item | ||
|
|
||
| # Merge UISettings schema component | ||
| for schema_name, schema_def in ( | ||
| ui_schema.get("components", {}).get("schemas", {}).items() | ||
| ): | ||
| openapi_schema["components"]["schemas"][schema_name] = schema_def | ||
|
Comment on lines
+19
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 2. Overbroad schema merge • The generator comment says it is merging the UISettings schema component, but it actually copies *all* schemas from the UI app into the API schema. • It overwrites existing component schemas unconditionally, so shared schema names (e.g., FastAPI’s common validation schemas) can be silently replaced, changing generated client types unexpectedly. • This makes the OSS schema sensitive to unrelated UI schema changes and can introduce hard-to-debug diffs in downstream generated code. Agent Prompt
|
||
|
|
||
| with open("oss_schema.json", "w") as f: | ||
| json.dump(openapi_schema, f) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Ui path prefix leaks
🐞 Bug• The OSS schema generator claims it will remove any UI base-path prefix, but it copies the UI app’s OpenAPI path verbatim. • Since the UI route is registered under PREFECT_UI_SERVE_BASE (via stripped_base_url), oss_schema.json can end up with /ui/ui-settings instead of /ui-settings, making client generation/configuration inconsistent. • The substring filter ("ui-settings" in path) is also fragile and can unintentionally merge other future endpoints containing that substring.Agent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools