feat(ui-v2): Add trigger form templates #177
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| import { useFormContext, useWatch } from "react-hook-form"; | ||
| import type { AutomationWizardSchema } from "@/components/automations/automations-wizard/automation-schema"; | ||
| import { | ||
| FormControl, | ||
| FormField, | ||
| FormItem, | ||
| FormLabel, | ||
| FormMessage, | ||
| } from "@/components/ui/form"; | ||
| import { Input } from "@/components/ui/input"; | ||
| import { Textarea } from "@/components/ui/textarea"; | ||
| import { PostureSelect } from "./posture-select"; | ||
|
|
||
| export const CustomTriggerFields = () => { | ||
| const form = useFormContext<AutomationWizardSchema>(); | ||
| const posture = useWatch<AutomationWizardSchema>({ name: "trigger.posture" }); | ||
|
|
||
| return ( | ||
| <div className="space-y-4"> | ||
| <div className="flex items-end gap-4"> | ||
| <PostureSelect /> | ||
| </div> | ||
|
|
||
| <FormField | ||
| control={form.control} | ||
| name="trigger.expect" | ||
| render={({ field }) => { | ||
| const events = field.value ?? []; | ||
| const textValue = events.join("\n"); | ||
| return ( | ||
| <FormItem> | ||
| <FormLabel>Expected Events (one per line)</FormLabel> | ||
| <FormControl> | ||
| <Textarea | ||
| placeholder="prefect.flow-run.Completed" | ||
| value={textValue} | ||
| onChange={(e) => { | ||
| const lines = e.target.value.split("\n"); | ||
| field.onChange(lines.length > 0 ? lines : undefined); | ||
| }} | ||
|
Comment on lines
+34
to
+40
There was a problem hiding this comment. 4. Custom events can't clear CustomTriggerFields uses split("\n") and then checks lines.length > 0, which is always true, so
clearing the textarea stores [""] instead of clearing the field. This prevents users from removing
expected events and can silently create a non-matching empty-string event entry.
Agent Prompt
|
||
| rows={4} | ||
| /> | ||
| </FormControl> | ||
| <FormMessage /> | ||
| </FormItem> | ||
| ); | ||
| }} | ||
| /> | ||
|
|
||
| <div className="flex gap-4"> | ||
| <FormField | ||
| control={form.control} | ||
| name="trigger.threshold" | ||
| render={({ field }) => ( | ||
| <FormItem className="w-32"> | ||
| <FormLabel>Threshold</FormLabel> | ||
| <FormControl> | ||
| <Input | ||
| type="number" | ||
| min={1} | ||
| {...field} | ||
| onChange={(e) => field.onChange(Number(e.target.value))} | ||
| /> | ||
| </FormControl> | ||
| <FormMessage /> | ||
| </FormItem> | ||
| )} | ||
| /> | ||
|
|
||
| {posture === "Proactive" && ( | ||
| <FormField | ||
| control={form.control} | ||
| name="trigger.within" | ||
| render={({ field }) => ( | ||
| <FormItem className="w-32"> | ||
| <FormLabel>Within (seconds)</FormLabel> | ||
| <FormControl> | ||
| <Input | ||
| type="number" | ||
| min={0} | ||
| {...field} | ||
| onChange={(e) => field.onChange(Number(e.target.value))} | ||
| /> | ||
| </FormControl> | ||
| <FormMessage /> | ||
| </FormItem> | ||
| )} | ||
| /> | ||
| )} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| import { useFormContext, useWatch } from "react-hook-form"; | ||
| import type { AutomationWizardSchema } from "@/components/automations/automations-wizard/automation-schema"; | ||
| import { | ||
| FormControl, | ||
| FormField, | ||
| FormItem, | ||
| FormLabel, | ||
| FormMessage, | ||
| } from "@/components/ui/form"; | ||
| import { Input } from "@/components/ui/input"; | ||
| import { | ||
| Select, | ||
| SelectContent, | ||
| SelectItem, | ||
| SelectTrigger, | ||
| SelectValue, | ||
| } from "@/components/ui/select"; | ||
| import { PostureSelect } from "./posture-select"; | ||
|
|
||
| const DEPLOYMENT_STATUSES = [ | ||
| { value: "prefect.deployment.ready", label: "Ready" }, | ||
| { value: "prefect.deployment.not-ready", label: "Not Ready" }, | ||
| ]; | ||
|
|
||
| export const DeploymentStatusTriggerFields = () => { | ||
| const form = useFormContext<AutomationWizardSchema>(); | ||
| const posture = useWatch<AutomationWizardSchema>({ name: "trigger.posture" }); | ||
|
|
||
| // Determine which field to use based on posture | ||
| const statusFieldName = | ||
| posture === "Proactive" ? "trigger.after" : "trigger.expect"; | ||
|
|
||
| return ( | ||
| <div className="space-y-4"> | ||
| <div className="flex items-end gap-4"> | ||
| <PostureSelect /> | ||
| <FormField | ||
| control={form.control} | ||
| name={statusFieldName} | ||
| render={({ field }) => { | ||
| const selectedStatus = field.value?.[0]; | ||
| return ( | ||
| <FormItem className="flex-1"> | ||
| <FormLabel>Status</FormLabel> | ||
| <FormControl> | ||
| <Select | ||
| value={selectedStatus ?? ""} | ||
| onValueChange={(value) => field.onChange([value])} | ||
| > | ||
| <SelectTrigger> | ||
| <SelectValue placeholder="Select status" /> | ||
| </SelectTrigger> | ||
| <SelectContent> | ||
| {DEPLOYMENT_STATUSES.map((status) => ( | ||
| <SelectItem key={status.value} value={status.value}> | ||
| {status.label} | ||
| </SelectItem> | ||
| ))} | ||
| </SelectContent> | ||
| </Select> | ||
| </FormControl> | ||
| <FormMessage /> | ||
| </FormItem> | ||
| ); | ||
| }} | ||
| /> | ||
| </div> | ||
|
|
||
| <div className="flex gap-4"> | ||
| <FormField | ||
| control={form.control} | ||
| name="trigger.threshold" | ||
| render={({ field }) => ( | ||
| <FormItem className="w-32"> | ||
| <FormLabel>Threshold</FormLabel> | ||
| <FormControl> | ||
| <Input | ||
| type="number" | ||
| min={1} | ||
| {...field} | ||
| onChange={(e) => field.onChange(Number(e.target.value))} | ||
| /> | ||
| </FormControl> | ||
| <FormMessage /> | ||
| </FormItem> | ||
| )} | ||
| /> | ||
|
|
||
| {posture === "Proactive" && ( | ||
| <FormField | ||
| control={form.control} | ||
| name="trigger.within" | ||
| render={({ field }) => ( | ||
| <FormItem className="w-32"> | ||
| <FormLabel>Within (seconds)</FormLabel> | ||
| <FormControl> | ||
| <Input | ||
| type="number" | ||
| min={0} | ||
| {...field} | ||
| onChange={(e) => field.onChange(Number(e.target.value))} | ||
| /> | ||
| </FormControl> | ||
| <FormMessage /> | ||
| </FormItem> | ||
| )} | ||
| /> | ||
| )} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| export { CustomTriggerFields } from "./custom-trigger-fields"; | ||
| export { DeploymentStatusTriggerFields } from "./deployment-status-trigger-fields"; | ||
| export { FlowRunStateTriggerFields } from "./flow-run-state-trigger-fields"; | ||
| export { PostureSelect } from "./posture-select"; | ||
| export { StateMultiSelect } from "./state-multi-select"; | ||
| export { TriggerStep } from "./trigger-step"; | ||
| export { getDefaultTriggerForTemplate } from "./trigger-step-utils"; | ||
| export { WorkPoolStatusTriggerFields } from "./work-pool-status-trigger-fields"; | ||
| export { WorkQueueStatusTriggerFields } from "./work-queue-status-trigger-fields"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Missing trigger-field component tests
📘 Rule violation⛯ ReliabilityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools