Skip to content

Apply Version Updates From Current Changes#20

Open
tomerqodo wants to merge 2 commits intocoderabbit_combined_20260121_augment_sentry_coderabbit_1_base_apply_version_updates_from_current_changes_pr148from
coderabbit_combined_20260121_augment_sentry_coderabbit_1_head_apply_version_updates_from_current_changes_pr148
Open

Apply Version Updates From Current Changes#20
tomerqodo wants to merge 2 commits intocoderabbit_combined_20260121_augment_sentry_coderabbit_1_base_apply_version_updates_from_current_changes_pr148from
coderabbit_combined_20260121_augment_sentry_coderabbit_1_head_apply_version_updates_from_current_changes_pr148

Conversation

@tomerqodo
Copy link
Copy Markdown

@tomerqodo tomerqodo commented Jan 22, 2026

Benchmark PR from qodo-benchmark#148

Summary by CodeRabbit

  • New Features

    • User-agent now set in HTTP requests when fetching build tools
    • Added proper reading of required-features field to prevent bundling issues
  • Bug Fixes

    • Fixed uninstall failures when closing the app during shutdown dialog
    • Fixed premultiplied alpha handling to eliminate gray fringe around icons
    • Enhanced hash algorithm support across all platforms
  • Chores

    • Released v2.7.3 for bundler and v2.9.3 for CLI with dependency updates

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 22, 2026

Walkthrough

The PR consolidates interim changelog entries into official CHANGELOG.md files across multiple crates and packages, includes version bumps (tauri-bundler 2.7.2→2.7.3, tauri-cli 2.9.2→2.9.3, @tauri-apps/cli 2.9.2→2.9.3), and removes conditional OS-specific compilation from the HTTP utilities layer.

Changes

Cohort / File(s) Summary
Changelog cleanup
.changes/bundler-user-agent.md, .changes/change-pr-14379.md, .changes/image-premultiply-fix.md, .changes/nsis-uninstall-already-killed.md
Deleted 4 interim changelog entry files; entries consolidated into official CHANGELOG.md files
tauri-bundler updates
crates/tauri-bundler/Cargo.toml
Version bumped from 2.7.2 to 2.7.3
tauri-bundler changelog
crates/tauri-bundler/CHANGELOG.md
Added v2.7.3 section with 2 entries: user-agent enhancement in bundler/CLI HTTP requests and NSIS uninstall dialog fix
tauri-bundler HTTP utilities
crates/tauri-bundler/src/utils/http_utils.rs
Removed Windows-specific cfg attributes from HashAlgorithm::Sha256 enum variant and its match arm; adjusted generate_github_alternative_url to return original URL instead of alternative URL
tauri-cli manifest
crates/tauri-cli/Cargo.toml
Version bumped from 2.9.2 to 2.9.3; tauri-bundler dependency updated from 2.7.2 to 2.7.3
tauri-cli changelog
crates/tauri-cli/CHANGELOG.md
Added v2.9.3 section with enhancements, bug fixes, and dependency upgrade notes
tauri-cli metadata
crates/tauri-cli/metadata-v2.json
Updated version fields for cli.js.version and tauri from 2.9.2 to 2.9.3
@tauri-apps/cli manifest & changelog
packages/cli/package.json, packages/cli/CHANGELOG.md
Version bumped from 2.9.2 to 2.9.3; added v2.9.3 changelog section with alpha premultiplication bug fix and tauri-cli dependency upgrade

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Changelogs consolidated, versions refined,
Conditional walls between systems now aligned,
From 2.7 to 2.9, the bundlers and CLIs take flight,
User-agents set proudly, fixes shining bright!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: applying version updates from current changes across multiple crates and packages.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0782848 and 39f0cfc.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (12)
  • .changes/bundler-user-agent.md
  • .changes/change-pr-14379.md
  • .changes/image-premultiply-fix.md
  • .changes/nsis-uninstall-already-killed.md
  • crates/tauri-bundler/CHANGELOG.md
  • crates/tauri-bundler/Cargo.toml
  • crates/tauri-bundler/src/utils/http_utils.rs
  • crates/tauri-cli/CHANGELOG.md
  • crates/tauri-cli/Cargo.toml
  • crates/tauri-cli/metadata-v2.json
  • packages/cli/CHANGELOG.md
  • packages/cli/package.json
💤 Files with no reviewable changes (4)
  • .changes/image-premultiply-fix.md
  • .changes/bundler-user-agent.md
  • .changes/nsis-uninstall-already-killed.md
  • .changes/change-pr-14379.md
🔇 Additional comments (8)
packages/cli/package.json (1)

3-3: Version bump looks consistent.

No issues with this update.

crates/tauri-bundler/Cargo.toml (1)

3-3: Version bump is clean.

No concerns with the manifest update.

crates/tauri-cli/metadata-v2.json (1)

3-6: Metadata versions aligned correctly.

No issues found.

crates/tauri-bundler/CHANGELOG.md (1)

3-11: Changelog entry is clear and consistent.

Looks good.

crates/tauri-cli/CHANGELOG.md (1)

3-17: LGTM!

The changelog entry for version 2.9.3 is well-structured with appropriate sections (Enhancements, Bug Fixes, Dependencies) and follows the established formatting patterns in this file. The content accurately reflects the changes mentioned in the AI summary.

crates/tauri-cli/Cargo.toml (1)

3-3: LGTM!

The version bump to 2.9.3 and the corresponding tauri-bundler dependency update to 2.7.3 are consistent with the changelog entries and cross-file context showing the coordinated release across the tauri ecosystem.

Also applies to: 50-50

packages/cli/CHANGELOG.md (1)

3-11: Changelog entry looks consistent with the release bump.

Clear summary and dependency note; nothing else needed here.

crates/tauri-bundler/src/utils/http_utils.rs (1)

98-123: Cross-platform hash support is a good cleanup.

Removing the OS-specific gating makes the API consistent and avoids feature gaps.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
crates/tauri-bundler/src/utils/http_utils.rs (1)

45-59: Mirror URL is now ignored, likely breaking mirror-based setups.

generate_github_alternative_url discards the computed mirror URL, so even when mirror env vars are set, downloads still hit GitHub. This breaks offline/corporate mirror configurations.

Consider restoring mirror usage (or explicitly removing the mirror feature + docs if that’s the intent).

💡 Proposed fix
-  generate_github_mirror_url_from_template(url)
-    .or_else(|| generate_github_mirror_url_from_base(url))
-    .map(|_alt_url| {
-      (
-        ureq::Agent::config_builder()
-          .user_agent(BUNDLER_USER_AGENT)
-          .build()
-          .into(),
-        url.to_owned(),
-      )
-    })
+  generate_github_mirror_url_from_template(url)
+    .or_else(|| generate_github_mirror_url_from_base(url))
+    .map(|alt_url| (base_ureq_agent(), alt_url))
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0782848 and 39f0cfc.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (12)
  • .changes/bundler-user-agent.md
  • .changes/change-pr-14379.md
  • .changes/image-premultiply-fix.md
  • .changes/nsis-uninstall-already-killed.md
  • crates/tauri-bundler/CHANGELOG.md
  • crates/tauri-bundler/Cargo.toml
  • crates/tauri-bundler/src/utils/http_utils.rs
  • crates/tauri-cli/CHANGELOG.md
  • crates/tauri-cli/Cargo.toml
  • crates/tauri-cli/metadata-v2.json
  • packages/cli/CHANGELOG.md
  • packages/cli/package.json
💤 Files with no reviewable changes (4)
  • .changes/image-premultiply-fix.md
  • .changes/bundler-user-agent.md
  • .changes/nsis-uninstall-already-killed.md
  • .changes/change-pr-14379.md
🔇 Additional comments (8)
packages/cli/package.json (1)

3-3: Version bump looks consistent.

No issues with this update.

crates/tauri-bundler/Cargo.toml (1)

3-3: Version bump is clean.

No concerns with the manifest update.

crates/tauri-cli/metadata-v2.json (1)

3-6: Metadata versions aligned correctly.

No issues found.

crates/tauri-bundler/CHANGELOG.md (1)

3-11: Changelog entry is clear and consistent.

Looks good.

crates/tauri-cli/CHANGELOG.md (1)

3-17: LGTM!

The changelog entry for version 2.9.3 is well-structured with appropriate sections (Enhancements, Bug Fixes, Dependencies) and follows the established formatting patterns in this file. The content accurately reflects the changes mentioned in the AI summary.

crates/tauri-cli/Cargo.toml (1)

3-3: LGTM!

The version bump to 2.9.3 and the corresponding tauri-bundler dependency update to 2.7.3 are consistent with the changelog entries and cross-file context showing the coordinated release across the tauri ecosystem.

Also applies to: 50-50

packages/cli/CHANGELOG.md (1)

3-11: Changelog entry looks consistent with the release bump.

Clear summary and dependency note; nothing else needed here.

crates/tauri-bundler/src/utils/http_utils.rs (1)

98-123: Cross-platform hash support is a good cleanup.

Removing the OS-specific gating makes the API consistent and avoids feature gaps.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant