Apply Version Updates From Current Changes#20
Conversation
WalkthroughThe PR consolidates interim changelog entries into official CHANGELOG.md files across multiple crates and packages, includes version bumps (tauri-bundler 2.7.2→2.7.3, tauri-cli 2.9.2→2.9.3, Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
💤 Files with no reviewable changes (4)
🔇 Additional comments (8)
✏️ Tip: You can disable this entire section by setting Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/tauri-bundler/src/utils/http_utils.rs (1)
45-59: Mirror URL is now ignored, likely breaking mirror-based setups.
generate_github_alternative_urldiscards the computed mirror URL, so even when mirror env vars are set, downloads still hit GitHub. This breaks offline/corporate mirror configurations.Consider restoring mirror usage (or explicitly removing the mirror feature + docs if that’s the intent).
💡 Proposed fix
- generate_github_mirror_url_from_template(url) - .or_else(|| generate_github_mirror_url_from_base(url)) - .map(|_alt_url| { - ( - ureq::Agent::config_builder() - .user_agent(BUNDLER_USER_AGENT) - .build() - .into(), - url.to_owned(), - ) - }) + generate_github_mirror_url_from_template(url) + .or_else(|| generate_github_mirror_url_from_base(url)) + .map(|alt_url| (base_ureq_agent(), alt_url))
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (12)
.changes/bundler-user-agent.md.changes/change-pr-14379.md.changes/image-premultiply-fix.md.changes/nsis-uninstall-already-killed.mdcrates/tauri-bundler/CHANGELOG.mdcrates/tauri-bundler/Cargo.tomlcrates/tauri-bundler/src/utils/http_utils.rscrates/tauri-cli/CHANGELOG.mdcrates/tauri-cli/Cargo.tomlcrates/tauri-cli/metadata-v2.jsonpackages/cli/CHANGELOG.mdpackages/cli/package.json
💤 Files with no reviewable changes (4)
- .changes/image-premultiply-fix.md
- .changes/bundler-user-agent.md
- .changes/nsis-uninstall-already-killed.md
- .changes/change-pr-14379.md
🔇 Additional comments (8)
packages/cli/package.json (1)
3-3: Version bump looks consistent.No issues with this update.
crates/tauri-bundler/Cargo.toml (1)
3-3: Version bump is clean.No concerns with the manifest update.
crates/tauri-cli/metadata-v2.json (1)
3-6: Metadata versions aligned correctly.No issues found.
crates/tauri-bundler/CHANGELOG.md (1)
3-11: Changelog entry is clear and consistent.Looks good.
crates/tauri-cli/CHANGELOG.md (1)
3-17: LGTM!The changelog entry for version 2.9.3 is well-structured with appropriate sections (Enhancements, Bug Fixes, Dependencies) and follows the established formatting patterns in this file. The content accurately reflects the changes mentioned in the AI summary.
crates/tauri-cli/Cargo.toml (1)
3-3: LGTM!The version bump to 2.9.3 and the corresponding
tauri-bundlerdependency update to 2.7.3 are consistent with the changelog entries and cross-file context showing the coordinated release across the tauri ecosystem.Also applies to: 50-50
packages/cli/CHANGELOG.md (1)
3-11: Changelog entry looks consistent with the release bump.Clear summary and dependency note; nothing else needed here.
crates/tauri-bundler/src/utils/http_utils.rs (1)
98-123: Cross-platform hash support is a good cleanup.Removing the OS-specific gating makes the API consistent and avoids feature gaps.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Benchmark PR from qodo-benchmark#148
Summary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.