chore: fix new clippy warnings (derive default)

[tomerqodo]

Benchmark PR from agentic-review-benchmarks#8

Summary by CodeRabbit

Release Notes

• Refactor

  • Simplified default value implementations across configuration types for improved code maintainability.

• Bug Fixes

  • Corrected mouse button state mappings in tray functionality.

• Tests

  • Added test helper for creating tray click events.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR refactors Default trait implementations across multiple Tauri crates, replacing manual impl Default blocks with derived Default and #[default] attribute annotations. Additionally, error message selection is consolidated using cfg_attr, and semantic adjustments are made to tray module conversions.

Changes

Cohort / File(s)	Summary
Default Derive Refactoring crates/tauri-cli/src/interface/rust.rs, crates/tauri-runtime/src/lib.rs, crates/tauri-utils/src/html.rs, crates/tauri-utils/src/lib.rs, crates/tauri/src/pattern.rs	Enum variants updated to use derive(Default) with #[default] attribute instead of manual impl Default blocks. Affected enums: WindowsUpdateInstallMode, DeviceEventFilter, IsolationSide, and TitleBarStyle.
Configuration Defaults crates/tauri-utils/src/config.rs, crates/tauri-utils/src/config_v1/mod.rs	Multiple enums converted to derived Default: BundleTarget, NsisCompression, NSISInstallerMode, PatternKind, WindowsUpdateInstallMode, and TitleBarStyle. Manual Default impls removed across both modules.
Error Message Configuration crates/tauri-bundler/src/error.rs	Consolidated per-target error messages for MissingBundleTypeVar variant using cfg_attr instead of separate conditional compilation blocks, selecting appropriate message based on target OS.
Tray Module Enhancements crates/tauri/src/tray/mod.rs	Added derive(Default) to MouseButtonState and MouseButton enums with #[default] attributes. Inverted conversion semantics: tray_icon::MouseButtonState::Up now maps to MouseButtonState::Down and vice versa. Added public constructor TrayIconEvent::new_click(id: TrayIconId).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Defaults refined with graceful ease,
derive replaces impl with breeze,
#[default] marks the chosen way,
Less boilerplate, cleaner today!
Tray semantics inverted bright, 🎪

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 21.43% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main objective of the pull request: addressing Clippy warnings by implementing derived Default implementations across multiple enums.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a860c1 and c8b8f92.

📒 Files selected for processing (9)

• crates/tauri-bundler/src/error.rs
• crates/tauri-cli/src/interface/rust.rs
• crates/tauri-runtime/src/lib.rs
• crates/tauri-utils/src/config.rs
• crates/tauri-utils/src/config_v1/mod.rs
• crates/tauri-utils/src/html.rs
• crates/tauri-utils/src/lib.rs
• crates/tauri/src/pattern.rs
• crates/tauri/src/tray/mod.rs

🧰 Additional context used

🧬 Code graph analysis (1)

crates/tauri/src/tray/mod.rs (1)

packages/api/src/tray.ts (3)

• MouseButtonState (10-10)
• MouseButton (11-11)
• TrayIconEvent (48-53)

🔇 Additional comments (19)

crates/tauri-runtime/src/lib.rs (1)

93-103: LGTM!

The refactor from a manual impl Default to #[derive(Default)] with #[default] on Unfocused is correct. This maintains the same default behavior while following modern Rust idioms (Rust 1.62+).

crates/tauri/src/pattern.rs (1)

66-76: LGTM!

The refactor correctly replaces the manual Default implementation with #[derive(Default)] and #[default] on the Original variant. The feature guard #[cfg(feature = "isolation")] is correctly preserved.

crates/tauri-cli/src/interface/rust.rs (1)

788-800: LGTM!

The refactor correctly replaces the manual Default implementation with #[derive(Default)] and #[default] on the Passive variant. This maintains the same default behavior.

crates/tauri-bundler/src/error.rs (1)

102-110: LGTM!

The use of #[cfg_attr] to select platform-specific error messages is clean and idiomatic. The Linux-specific message appropriately includes the symbol stripping note, which is relevant since stripping can interfere with the __TAURI_BUNDLE_TYPE variable detection.

crates/tauri/src/tray/mod.rs (4)

22-29: LGTM for the Default derive.

The #[derive(Default)] with #[default] on Up is appropriate for MouseButtonState.

---

41-50: LGTM for the Default derive.

The #[derive(Default)] with #[default] on Left is appropriate for MouseButton.

---

137-154: LGTM for the new constructor.

The new_click constructor provides a convenient way to create mock Click events for testing, using sensible default values. The use of MouseButton::default() and MouseButtonState::default() is appropriate here.

---

31-38: The From implementation is correct and intentionally inverts the conversion.

The mapping correctly converts between two different semantic conventions: tray-icon uses standard button state semantics (Up = released, Down = pressed), while Tauri's MouseButtonState uses inverted semantics (Up = pressed, Down = released). The current implementation properly converts between them:

• tray_icon::Up (released) → MouseButtonState::Down (released) ✓
• tray_icon::Down (pressed) → MouseButtonState::Up (pressed) ✓

No changes needed. The implementation is semantically correct.

crates/tauri-utils/src/lib.rs (1)

160-178: LGTM!

The refactor correctly replaces the manual Default implementation with #[derive(Default)] and #[default] on the Visible variant. This maintains the same default behavior while the custom Serialize and Deserialize implementations remain in place.

crates/tauri-utils/src/html.rs (1)

214-219: Default remains Original for IsolationSide.
Behavior stays aligned with the previous manual default.

crates/tauri-utils/src/config.rs (4)

210-215: BundleTarget default remains All.
Keeps the previous default selection intact.

---

803-813: NsisCompression default remains Lzma.
Default compression choice is preserved.

---

818-829: NSISInstallerMode default remains CurrentUser.
No change in default installer mode behavior.

---

2671-2679: PatternKind default remains Brownfield.
Default pattern selection stays consistent.

crates/tauri-utils/src/config_v1/mod.rs (5)

133-138: v1 BundleTarget default remains All.
Default bundle target behavior is preserved.

---

549-560: v1 NSISInstallerMode default remains CurrentUser.
Installer mode default is unchanged.

---

2384-2392: v1 PatternKind default remains Brownfield.
Default pattern selection stays consistent.

---

2468-2480: WindowsUpdateInstallMode default remains Passive.
Keeps the same update install default.

---

2971-2977: TitleBarStyle default remains Visible.
No behavior change in title bar default.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}