fix(bounds): adjust weekly bounds when run on Sunday #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
#sre-storage |
Contributor
|
I've tested this change locally, this was indeed a nasty bug. Nice catch Daniel 👏 |
The expression -int(date.Weekday()-time.Monday) was used as an offset from today back to the previous monday. But since time.Sunday=0, it goes into the next week when run on Sunday, producing incorrect partitions bounds. Also add tests for partition.getWeeklyBounds() Signed-off-by: Daniel Vérité <dverite@gmail.com>
dverite
force-pushed
the
fix-weekly-sunday-issue
branch
from
6ae8558 to
0b53739
Compare
Minimum allowed line rate is |
Collaborator
Author
|
Squashed the commits. It should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expression -int(date.Weekday()-time.Monday) was used as an offset from today back to the previous monday. But since time.Sunday=0, it goes into the next week when run on Sunday, producing incorrect partitions bounds.