Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds_instance_status): metric description and doc in readme #242

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

qfritz
Copy link
Contributor

@qfritz qfritz commented Feb 25, 2025

No description provided.

Copy link

Code Coverage

Package Line Rate Health
github.com/qonto/prometheus-rds-exporter/cmd 0%
github.com/qonto/prometheus-rds-exporter/internal/app/cloudwatch/mock 100%
github.com/qonto/prometheus-rds-exporter/internal/app/cloudwatch 87%
github.com/qonto/prometheus-rds-exporter/internal/app/ec2 87%
github.com/qonto/prometheus-rds-exporter/internal/app/ec2/mock 51%
github.com/qonto/prometheus-rds-exporter/internal/app/exporter 80%
github.com/qonto/prometheus-rds-exporter/internal/app/rds 67%
github.com/qonto/prometheus-rds-exporter/internal/app/rds/mock 89%
github.com/qonto/prometheus-rds-exporter/internal/app/servicequotas/mock 47%
github.com/qonto/prometheus-rds-exporter/internal/app/servicequotas 67%
github.com/qonto/prometheus-rds-exporter/internal/app/trace 100%
github.com/qonto/prometheus-rds-exporter/internal/app/unit 100%
github.com/qonto/prometheus-rds-exporter/internal/infra/http 0%
github.com/qonto/prometheus-rds-exporter/internal/infra/logger 79%
github.com/qonto/prometheus-rds-exporter/internal/infra/tracing 0%
github.com/qonto/prometheus-rds-exporter 0%
Summary 64% (1193 / 1856)

Minimum allowed line rate is 60%

Copy link
Contributor

@dcupif dcupif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@qfritz qfritz merged commit 88950eb into main Feb 25, 2025
9 of 11 checks passed
@qfritz qfritz deleted the fix-rds-status-doc branch February 25, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants