Fix tests#273
Open
vmercierfr wants to merge 4 commits into
Open
Conversation
…dependent failures Replace hardcoded past dates (2025-12-31) with time.Now().AddDate() so remaining days are always positive regardless of when tests run. Signed-off-by: Vincent Mercier <vmercier@gmail.com>
Return an error from DescribeDBMajorEngineVersions when both output and error are nil, preventing the AWS SDK paginator from panicking on nil pointer dereference inside NextPage(). Signed-off-by: Vincent Mercier <vmercier@gmail.com>
…ation tests Add CollectEngineSupport: true to all test configurations that expect engine support metrics. Fix expectedAPICallCount for mixed engine test to 3 since the API is called once per unique engine type. Signed-off-by: Vincent Mercier <vmercier@gmail.com>
…ns in exporter unit tests Add CollectEngineSupport: true to test configurations. Fix MajorEngineVersion values to use major-only versions (e.g. '14' not '14.9') matching extractMajorVersion behavior. Correct API call expectation in MetricsDisabled test and engine filtering for non-PostgreSQL engines. Signed-off-by: Vincent Mercier <vmercier@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectif
Fix tests
Why
Tests are broken, could be related to changes from !269
How
Fix 4 tests
Release
Release fix version