fix(yield-wrapper): prevent circular reference in node replacement #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#web |
Collaborator
|
I'm curious, how did you validate this solved it? Also, do you know why this happens in the first place? |
SkoebaSteve
approved these changes
Apr 2, 2025
wandroll
force-pushed
the
fix_yield-wrapper-circular-reference
branch
from
7988cd3 to
9427808
Compare
wandroll
force-pushed
the
fix_yield-wrapper-circular-reference
branch
from
158d3bc to
639263c
Compare
Contributor
Author
|
The test show I didn't break anything but I have not been able to recreate a test case that would demonstrate the issue at hand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add safety check to filter out wrapper element from nodes to avoid DOM circular reference error when replacing nodes in YieldWrapper component.
This would fix those sentry error
https://qonto.sentry.io/issues/6337008249/?project=160009