Align onDeferredPurchaseCompleted param name with iOS (purchaseResult)#319
Merged
Merged
Conversation
Rename the supertype param from `transaction` to `purchaseResult` in `QonversionEventsListener.onDeferredPurchaseCompleted`. Aligns with iOS naming (RNQonversion.mm uses `purchaseResult`) and the param naming already chosen in react-native-sdk and flutter-sdk overrides. Without this rename, both react-native-sdk and flutter-sdk emit a Kotlin compiler warning on every build: warning: the corresponding parameter in the supertype 'QonversionEventsListener' is named 'transaction'. This may cause problems when calling this function with named arguments. (See react-native-sdk #439 for the original report.) The only call site within sandwich-sdk (QonversionSandwich.kt:512) passes a positional argument, so this is purely a metadata change for existing Java/Kotlin callers. No named-argument callers exist in the Qonversion repos. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
SpertsyanKM
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the supertype param from `transaction` to `purchaseResult` in `QonversionEventsListener.onDeferredPurchaseCompleted`. Aligns with iOS naming (`RNQonversion.mm` uses `purchaseResult`) and the param name already chosen by the override in react-native-sdk and flutter-sdk.
Without this rename, both react-native-sdk and flutter-sdk emit a Kotlin compiler warning on every build:
```
warning: the corresponding parameter in the supertype 'QonversionEventsListener' is named 'transaction'. This may cause problems when calling this function with named arguments.
```
(See react-native-sdk #439 for the original report.)
Compatibility
Follow-up after release
Once a sandwich version containing this change is published, two follow-up PRs will bump the dep:
Single-line change, +1/-1.