Skip to content

572 join error #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Bob versions changelog


#### Fixed
- Error propagation for JoinHandle errors (#572)


#### Updated
Expand Down
9 changes: 5 additions & 4 deletions bob/src/cluster/operations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ fn is_result_successful(
},
Err(e) => {
error!("{:?}", e);
errors.push(NodeOutput::new(
"unknown".to_string(),
Error::failed(e.to_string()),
))
}
}
0
Expand Down Expand Up @@ -278,10 +282,7 @@ pub(crate) async fn put_local_node(
backend.put_local(key, data, op).await
}

pub(crate) async fn delete_at_local_node(
backend: &Backend,
key: BobKey,
) -> Result<(), Error> {
pub(crate) async fn delete_at_local_node(backend: &Backend, key: BobKey) -> Result<(), Error> {
debug!("local node has vdisk replica, put local");
backend.delete(key).await?;
Ok(())
Expand Down