-
Notifications
You must be signed in to change notification settings - Fork 3
572 join error #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
idruzhitskiy
wants to merge
14
commits into
master
Choose a base branch
from
572-join-error
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
572 join error #670
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c1a2dc6
save joinhandle errors as made by unknown node
idruzhitskiy e50f171
revert style change
54bf9a5
add missing comma
c568004
move joinhandle error processing
932a37d
Revert "move joinhandle error processing"
7178710
add panic
7a16b5f
merge master
223b88f
add missing panic
8bcc6a6
fix discussion
5b40f4f
fix bob/832
6b1729c
fix misuse of new type
c0bbe7a
merge master
2e20b2a
remove unnecessary change
cd97b17
Merge branch 'master' into 572-join-error
idruzhitskiy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ Bob versions changelog | |
|
||
|
||
#### Fixed | ||
- Error propagation for JoinHandle errors (#572) | ||
|
||
|
||
#### Updated | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.