Skip to content

730 crossplatform metrics #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

730 crossplatform metrics #867

wants to merge 29 commits into from

Conversation

idruzhitskiy
Copy link
Contributor

@idruzhitskiy idruzhitskiy commented Feb 8, 2024 •
edited
Loading

Closes #730

@idruzhitskiy idruzhitskiy requested review from ikopylov and removed request for ikopylov February 8, 2024 13:36
@idruzhitskiy idruzhitskiy marked this pull request as ready for review February 16, 2024 11:47
@ikopylov
Copy link
Member

ikopylov commented Mar 1, 2024

Here is the issue with incorrect disk space calculation on MacOs: #825

frsize field should be used instead of bsize in the calculation logic. You can temporary change the field and verify the calculation on macOs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikopylov ikopylov Awaiting requested review from ikopylov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make hardware metrics crossplatform
2 participants
@idruzhitskiy @ikopylov