Refactor container creation to use context and saver #1031
+73
−46
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -936,7 +936,7 @@ func (b *Builder) firstOrCreateDemoContainers(ctx *web.EventContext, cons ...*Co | |
| cons = b.containerBuilders | ||
| } | ||
| for _, con := range cons { | ||
| if err := con.firstOrCreate(ctx, slices.Concat(localeCodes)); err != nil { | ||
| continue | ||
| } | ||
| } | ||
|
|
@@ -1320,20 +1320,25 @@ func (b *ContainerBuilder) getContainerDataID(modelID int, primarySlug string) s | |
| return fmt.Sprintf(inflection.Plural(strcase.ToKebab(b.name))+"_%v_%v", modelID, primarySlug) | ||
| } | ||
|
|
||
| func (b *ContainerBuilder) firstOrCreate(ctx *web.EventContext, localeCodes []string) (err error) { | ||
| var ( | ||
| db = b.builder.db | ||
| obj = b.mb.NewModel() | ||
| cons []*DemoContainer | ||
| m = &DemoContainer{} | ||
| saver = b.mb.Editing().Creating().Saver | ||
| ) | ||
| if len(localeCodes) == 0 { | ||
| return | ||
| } | ||
| ctx.R.Form.Set(ParamContainerCreate, "1") | ||
| return db.Transaction(func(tx *gorm.DB) (vErr error) { | ||
| ctx.WithContextValue(gorm2op.CtxKeyDB{}, tx) | ||
| defer ctx.WithContextValue(gorm2op.CtxKeyDB{}, nil) | ||
| tx.Where("model_name = ? and locale_code in ? ", b.name, localeCodes).Find(&cons) | ||
|
|
||
| if len(cons) == 0 { | ||
| if vErr = saver(obj, "", ctx); vErr != nil { | ||
|
There was a problem hiding this comment. Bug: Nil Saver Causes Panic, Context Update FailsThe There was a problem hiding this comment. [nitpick] The empty string parameter passed to saver is unclear. Consider using a named constant or adding a comment to explain what this parameter represents. Copilot uses AI. Check for mistakes. |
||
| return | ||
| } | ||
| modelID := reflectutils.MustGet(obj, "ID").(uint) | ||
|
|
@@ -1364,7 +1369,7 @@ func (b *ContainerBuilder) firstOrCreate(localeCodes []string) (err error) { | |
| continue | ||
| } | ||
| obj = b.mb.NewModel() | ||
| if vErr = saver(obj, "", ctx); vErr != nil { | ||
| return | ||
| } | ||
| modelID := reflectutils.MustGet(obj, "ID").(uint) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The context value is being set and then immediately cleared in the defer statement, which means the database transaction will not be available to the saver function. The defer should be moved after the saver calls or the context clearing should be removed.
Copilot uses AI. Check for mistakes.