Skip to content

Conversation

shenzhaoyan
Copy link
Contributor

No description provided.

@shenzhaoyan shenzhaoyan requested a review from a team October 21, 2025 02:32
Copy link

deepsource-io bot commented Oct 21, 2025

Here's the code health analysis summary for commits 5194403..ae6ed0b. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ Success
🎯 7 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
worker/builder.go 85.00% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
worker/builder.go 54.67% <85.00%> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@molon molon requested a review from Copilot October 21, 2025 02:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an auto-refresh issue for Worker job status updates by moving the refresh interval management from server-side JavaScript execution to declarative component initialization and Vue lifecycle hooks.

Key Changes:

  • Removed server-side RunScript calls that set worker_updateJobProgressingInterval in event handlers
  • Implemented declarative refresh interval initialization using web.Scope().Init() based on job status
  • Added v-on-mounted hook to dynamically update refresh intervals when job progress UI renders

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@shenzhaoyan shenzhaoyan merged commit 4ae3c8d into main Oct 21, 2025
10 checks passed
@shenzhaoyan shenzhaoyan deleted the fix-worker-auto-refresh-issue branch October 21, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants