Refactor role selection and error handling in user and TOTP setup #1038
+184
−207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused selectedItems variable from user role component functions in user_config.go and user.go. Improved error handling in TOTP setup page by checking for errors from otp.NewKeyFromURL and returning appropriate error messages. Simplified buffer handling and error return in OSS file retrieval handler.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Here's the code health analysis summary for commits Analysis Summary
|
Replaces all instances of 'len(str) > 0' with 'str != ""' for string emptiness checks in editing.go and simplifies variable initialization in list_publish_builder.go. This improves code readability and consistency.
Replaces nil with http.NoBody in HTTP request creation across tests for clarity and future compatibility. Refactors some variable initializations, improves error wrapping with fmt.Errorf, simplifies string concatenations, and removes unnecessary return statements. Also includes minor logic improvements and code style adjustments in several modules.
Replaces usage of %v with %w in error wrapping for better error propagation in data_init.go. Refactors several functions in login/views.go, publish/list_publish_builder.go, and seo/seo.go to remove unnecessary else branches and simplify control flow, improving readability and maintainability.
Replaces explicit empty slice initializations (e.g., []Type{}) with 'var' declarations for slices and maps across multiple files. This improves code readability and consistency, and in some cases sets slices/maps to nil instead of empty, which can be more idiomatic in Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused selectedItems variable from user role component functions in user_config.go and user.go. Improved error handling in TOTP setup page by checking for errors from otp.NewKeyFromURL and returning appropriate error messages. Simplified buffer handling and error return in OSS file retrieval handler.