expose scheduler now func #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the scheduler’s current time function by renaming the internal nowFunc to the exported NowFunc, allowing tests to override it. Additionally, a Go workflow is added for building and testing the project.
- Renamed nowFunc to NowFunc in scheduler.go and scheduler_test.go.
- Updated all references accordingly in tests and production code.
- Introduced a new GitHub Actions workflow in .github/workflows/go.yml.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scheduler/scheduler_test.go | Updated test references to use the exported NowFunc and adjusted test setups accordingly. |
| scheduler/scheduler.go | Renamed nowFunc to NowFunc to allow external overriding, with corresponding documentation update. |
| .github/workflows/go.yml | Added workflow file to automate build and test processes for the Go project. |
molon
reviewed
Jun 20, 2025
.github/workflows/go.yml
Outdated
| - name: Test | ||
| run: go test -p=1 -count=1 -failfast -coverprofile=coverage.txt -coverpkg=github.com/qor5/... ./... | ||
| env: | ||
| GO_TESTING: "TRUE" No newline at end of file |
.github/workflows/go.yml
Outdated
| branches: [ "main", "develop" ] | ||
|
|
||
| permissions: | ||
| id-token: write |
.github/workflows/go.yml
Outdated
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: [ "main", "develop" ] |
iBakuman
force-pushed
the
expose-scheduler-nowfunc
branch
from
9531ef6 to
79a8b29
Compare
…n in TestEnqueueLockUnlock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.