Skip to content

fix: json marshaling of 'contains' schema #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RichardKnop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: json marshaling of 'contains' schema #125

RichardKnop wants to merge 1 commit into from

Conversation

@RichardKnop
Copy link

@RichardKnop RichardKnop commented May 2, 2024 •
edited
Loading

Marshalling a schema with contains keyword will currently always output:

{
  "contains": {}
}

Ignoring entire schema inside contains. This PR fixes the behaviour so marshalling works as expected.

Linked issue: #126

@b5

@RichardKnop RichardKnop mentioned this pull request May 2, 2024
Open
@RichardKnop RichardKnop force-pushed the fix/contains-json-marshal branch from e5a8e91 to 074eecb Compare May 3, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nsuidak nsuidak nsuidak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RichardKnop @nsuidak