[6788][ADD] maintenance_equipment_additional_attributes: add specific attributes to maintenance equipment by smorita7749 · Pull Request #9 · qrtl/rbkk-custom

smorita7749 · 2026-07-03T03:27:57Z

Add a new module that extends maintenance.equipment with RBKK-specific attributes:

Set Name (Char)
General Name (Many2one master, creatable inline; managed under Maintenance / Configuration)
National Project ID (Many2one master; managed under Maintenance / Configuration)
Fixed Asset flag + Fixed Asset Code (shown only when Fixed Asset is set)
GMP flag + GMP Function (Manufacturing / QC) + GMP Category (A / B / C), shown only when GMP is set
Measuring Instrument flag
Used in location (Many2one stock.location, internal locations only, tracked) — replaces the base free-text location on the form
Manufacturer (Char)
Acquisition Date (Date)

Includes Japanese translation (i18n/ja.po).

…butes to maintenance equipment Extend maintenance.equipment with RBKK-specific attributes: set name, general name (master), national project (master), fixed asset flag/code, GMP flag with function and category, measuring instrument flag, location in use (stock.location), manufacturer and acquisition date. task-6788

…layout These two modules were dropped by the ours-style merge c2fe042 ("fixup!"), which recorded 54185f3 as a parent but kept only the feature branch tree. Recover them unchanged from 54185f3.

…ription Also dropped by the ours-merge c2fe042: test-requirements.txt (test dep stock_reporting_access needed by stock_location_report_manager_layout) and the regenerated purchase_security_adjust static description. Recover from 54185f3.

…etion

…ompletion

…alert period unit

smorita7749 · 2026-07-24T08:39:59Z

Add ja.po

Translation notes

Translations are referenced from existing Odoo translations where available (odoo/maintenance, odoo/purchase).

The following terms have no reference and are translated independently:

msgid	msgstr
Alert Period	アラート期間
Alert Period Uom	アラート期間の単位
Alert Sent	アラート送信済み
Amount of time before the scheduled date at which the responsible user should be alerted about this maintenance.	予定日より前に担当者へアラートを通知する期間。

- Rename alert_period_uom to alert_period_unit - Add unique name constraint on equipment department and general name - Simplify alert_sent field definition

AungKoKoLin1997 · 2026-07-29T01:47:48Z

+    alert_period = fields.Integer(
+        help="Amount of time before the scheduled date at which the "
+        "responsible user should be alerted about this maintenance.",
+    )
+    alert_period_unit = fields.Selection(
+        selection=[
+            ("day", "Days"),
+            ("week", "Weeks"),
+            ("month", "Months"),
+        ],
+        default="month",
+    )
+    alert_sent = fields.Boolean(copy=False)


What is the purpose of these fields? Don't we need any action method?

This is to make to-do activities via cron managed in the settings in UI.
I recorded the cron in the ticket.

Is there any reason to create cron manually instead of adding in the module?

I think adding this module is out of range, and cutting out to another module is too much.
Is it acceptable to add it to this module?

The purpose of those fields are for sending alert to the user. So, having the fields but not having action is a bit strange. In my opinion, it is okay to add it in this module but you can also create a separate module for these fields and action. You can ask advice with claude.

AungKoKoLin1997 · 2026-07-29T07:40:36Z

+        <field name="model">maintenance.equipment.department</field>
+        <field name="arch" type="xml">
+            <list editable="bottom">
+                <field name="name" />


Also add active field with boolean_toggle widget.

AungKoKoLin1997 · 2026-07-29T07:40:56Z

+    <record id="maintenance_equipment_department_view_form" model="ir.ui.view">
+        <field name="name">maintenance.equipment.department.form</field>
+        <field name="model">maintenance.equipment.department</field>
+        <field name="arch" type="xml">
+            <form>
+                <sheet>
+                    <group>
+                        <field name="name" />
+                    </group>
+                </sheet>
+            </form>
+        </field>
+    </record>


Editable list view is enough.

Suggested change

<record id="maintenance_equipment_department_view_form" model="ir.ui.view">

<field name="name">maintenance.equipment.department.form</field>

<field name="model">maintenance.equipment.department</field>

<field name="arch" type="xml">

<form>

<sheet>

<group>

<field name="name" />

</group>

</sheet>

</form>

</field>

</record>

AungKoKoLin1997 · 2026-07-29T07:41:03Z

+    <record id="maintenance_equipment_department_action" model="ir.actions.act_window">
+        <field name="name">Departments</field>
+        <field name="res_model">maintenance.equipment.department</field>
+        <field name="view_mode">list,form</field>


Suggested change

<field name="view_mode">list,form</field>

<field name="view_mode">list</field>

AungKoKoLin1997 · 2026-07-29T07:41:21Z

Same as above.

smorita7749 added 4 commits July 3, 2026 03:26

fixup!

c2fe042

[FIX] restore purchase_line_budget and stock_location_report_manager_…

fd9a396

…layout These two modules were dropped by the ours-style merge c2fe042 ("fixup!"), which recorded 54185f3 as a parent but kept only the feature branch tree. Recover them unchanged from 54185f3.

smorita7749 force-pushed the 6788-add-maintenance_equipment_additional_attributes branch from 8056cb8 to f455cb1 Compare July 16, 2026 01:18

fixup!

66565d6

smorita7749 force-pushed the 6788-add-maintenance_equipment_additional_attributes branch from f455cb1 to 66565d6 Compare July 22, 2026 10:43

smorita7749 added 2 commits July 23, 2026 15:10

[IMP] maintenance_additional_attributes: show close date before compl…

523788c

…etion

[IMP] maintenance_additional_attributes: keep close date entered on c…

d254fa3

…ompletion

smorita7749 force-pushed the 6788-add-maintenance_equipment_additional_attributes branch from 159c59f to d254fa3 Compare July 23, 2026 15:27

smorita7749 added 2 commits July 24, 2026 08:39

[IMP] maintenance_additional_attributes: add purchase order link and …

96f00e5

…alert period unit

[IMP] maintenance_additional_attributes: Add translations

ca76dac

AungKoKoLin1997 reviewed Jul 28, 2026

View reviewed changes

smorita7749 added 3 commits July 28, 2026 09:50

[IMP] maintenance_additional_attributes: add equipment image

def9449

fixup! [IMP] maintenance_additional_attributes: add equipment image

328f442

[IMP] maintenance_additional_attributes: address review comments

fd7bc18

- Rename alert_period_uom to alert_period_unit - Add unique name constraint on equipment department and general name - Simplify alert_sent field definition

smorita7749 requested a review from AungKoKoLin1997 July 29, 2026 01:41

AungKoKoLin1997 reviewed Jul 29, 2026

View reviewed changes

fixup!

0b371d3

AungKoKoLin1997 reviewed Jul 29, 2026

View reviewed changes

	<field name="view_mode">list,form</field>
	<field name="view_mode">list</field>

Uh oh!

Conversation

smorita7749 commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smorita7749 commented Jul 24, 2026

Translation notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

smorita7749 commented Jul 3, 2026 •

edited

Loading