Skip to content

[4981][FIX] attachment_image_resize: fix not setting resize_done to true when create new attachment#64

Merged
kanda999 merged 1 commit into
15.0from
15.0-imp-attachment_image_resize
Nov 20, 2025
Merged

[4981][FIX] attachment_image_resize: fix not setting resize_done to true when create new attachment#64
kanda999 merged 1 commit into
15.0from
15.0-imp-attachment_image_resize

Conversation

@AungKoKoLin1997

Copy link
Copy Markdown
Contributor

4981
Only the previous logic is not covered to set the resize_done to True since there is still no record at the time of image processing during creation.

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 Can you please clarify what the issue we are facing is. While I think the proposed change is probably needed, I wasn't sure it was addressing the issue.

@AungKoKoLin1997

Copy link
Copy Markdown
Contributor Author

@AungKoKoLin1997 Can you please clarify what the issue we are facing is. While I think the proposed change is probably needed, I wasn't sure it was addressing the issue.

@yostashiro The issue we are facing now is the resize_done is never True when the attachment is created but the resizing is working well. It is because of self is still not a record in _postprocess_contents during creation.
So, resize_done is never assigned for the new creation.

@yostashiro

Copy link
Copy Markdown
Member

@AungKoKoLin1997 In that case, shouldn't we instead update _postprocess_contents() by updating values when self is not a record? The suggested update blurs the intention without a comment.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-imp-attachment_image_resize branch from cc6f646 to f39139f Compare October 17, 2025 07:27

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nobuQuartile nobuQuartile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Functional review
Code review

@kanda999 kanda999 merged commit ba33643 into 15.0 Nov 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants