-
Notifications
You must be signed in to change notification settings - Fork 249
When core crashes, restart workers and show a UI #3236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: qa
Are you sure you want to change the base?
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #3236 +/- ##
==========================================
+ Coverage 89.54% 91.33% +1.79%
==========================================
Files 429 344 -85
Lines 86502 78113 -8389
==========================================
- Hits 77456 71345 -6111
+ Misses 9046 6768 -2278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
value: String, | ||
cursor: Option<String>, | ||
) -> Result<(), JsValue> { | ||
panic!("Oh shit!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temp leaving this in for testing and design.
Relevant issue(s)
[insert link(s) here]
Description
This should sufficiently describe the functionality added/improved in the PR.
(Optional) Testing considerations
E.g. "this changes the core functionality of tables, all the basic table functionality should be validated to be working as expected."
(Optional) QA Wolf tests
Please notify here if you'd like a test created in QA Wolf to accompany this PR.
(Optional) Dependent docs, links, etc.
E.g. "@Xyzperson need docs link to security page for link in-app"