Skip to content

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Sep 1, 2025

  • remove analytics in index.html and rely on ones in analytics.ts (looks like had multiple google analytics attachments)
  • don't fetch user profile images when in dev (google doesn't like localhost as a host)
  • remove the install React DevTools message

Testing:

  • Double check analytics still works

Copy link

qa-wolf bot commented Sep 1, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Sep 1, 2025
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Preview - Build, Deploy & Tests-E2E

✅ Build images
✅ Deploy images - Sep 09, 2025 at 02:00 PM UTC - Preview
⏳ Tests-E2E

🔍 Please check the workflow run for details.

@github-actions github-actions bot temporarily deployed to preview-pr-3395 September 1, 2025 22:24 Destroyed
@davidfig davidfig self-assigned this Sep 1, 2025
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (2168ca6) to head (cb0524a).

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #3395   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files         434      434           
  Lines       89057    89057           
=======================================
  Hits        79906    79906           
  Misses       9151     9151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidfig davidfig changed the title Hiding analytics and dev errors in console Hide analytics and dev errors in console Sep 1, 2025
@github-actions github-actions bot temporarily deployed to preview-pr-3395 September 1, 2025 22:33 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-3395 September 9, 2025 13:28 Destroyed
@cole-at-quadratic
Copy link

We can remove code for the Google Tag Manager property: GTM-WVC2XPB3

Keep code for GTM-MDFG6DX4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants