Skip to content

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Sep 27, 2025

Prototype for animating tables that are currently running.

Closes #2935

CleanShot.2025-09-27.at.13.12.02.mp4

@davidfig davidfig self-assigned this Sep 27, 2025
Copy link

qa-wolf bot commented Sep 27, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Sep 27, 2025
Copy link
Contributor

github-actions bot commented Sep 27, 2025

Preview - Build, Deploy & Tests-E2E

✅ Build images
✅ Deploy images - Sep 27, 2025 at 08:31 PM UTC - Preview
✅ Tests-E2E - Report

Copy link

codecov bot commented Sep 27, 2025

Codecov Report

❌ Patch coverage is 90.85366% with 225 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.62%. Comparing base (1be37c7) to head (5838a1d).

Files with missing lines Patch % Lines
quadratic-core/src/grid/sheet/ai_context.rs 0.00% 39 Missing ⚠️
...dratic-core/src/controller/operations/clipboard.rs 79.86% 30 Missing ⚠️
.../execution/execute_operation/execute_data_table.rs 80.31% 25 Missing ⚠️
quadratic-core/src/grid/file/v1_11/upgrade.rs 83.83% 16 Missing ⚠️
quadratic-core/src/grid/sheet/rendering/cells.rs 80.51% 15 Missing ⚠️
quadratic-core/src/grid/file/sheet_schema.rs 27.77% 13 Missing ⚠️
quadratic-core/src/grid/sheet/code.rs 74.00% 13 Missing ⚠️
...atic-core/src/controller/execution/run_code/mod.rs 86.27% 7 Missing ⚠️
quadratic-core/src/grid/data_table/code_run/mod.rs 81.57% 7 Missing ⚠️
quadratic-core/src/test_util/assert_data_table.rs 82.05% 7 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #3482      +/-   ##
==========================================
- Coverage   89.76%   89.62%   -0.15%     
==========================================
  Files         437      438       +1     
  Lines       90135    90068      -67     
==========================================
- Hits        80913    80726     -187     
- Misses       9222     9342     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better loading indicators for long running tables

2 participants