Skip to content

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Sep 28, 2025

Relevant issue(s)

Closes #3371

  • UI for replacing a table
  • replace table when overwriting

Copy link

qa-wolf bot commented Sep 28, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Sep 28, 2025
@davidfig davidfig self-assigned this Sep 28, 2025
Copy link
Contributor

github-actions bot commented Sep 28, 2025

Preview - Build, Deploy & Tests-E2E

✅ Build images
✅ Deploy images - Oct 04, 2025 at 07:06 PM UTC - Preview
❌ Tests-E2E - Report

@github-actions github-actions bot temporarily deployed to preview-pr-3483 September 28, 2025 14:57 Destroyed
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 47.50000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.74%. Comparing base (bf9610c) to head (7dc5e4e).

Files with missing lines Patch % Lines
quadratic-core/src/controller/operations/import.rs 28.57% 20 Missing ⚠️
...adratic-core/src/controller/user_actions/import.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #3483      +/-   ##
==========================================
- Coverage   89.76%   89.74%   -0.02%     
==========================================
  Files         437      437              
  Lines       90129    90167      +38     
==========================================
+ Hits        80905    80922      +17     
- Misses       9224     9245      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to preview-pr-3483 September 28, 2025 15:02 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-3483 September 28, 2025 15:37 Destroyed
@davidfig davidfig changed the title UI for replace table UI for replace table during import Sep 28, 2025
@davidfig davidfig changed the title UI for replace table during import Replace table during import Sep 29, 2025
@github-actions github-actions bot temporarily deployed to preview-pr-3483 October 3, 2025 13:24 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropping file over table replaces table with new file data

1 participant