Skip to content

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Oct 5, 2025

This adds a 1d query option for connections. Note: this is a naked list of values separated by commas. The user will have to provide quotes or other means of parsing this list in the SQL query. I've added this information to the AI prompting.

  • allow 1d SQL query, which will return comma-delimited list of values (e.g., 123,hello,456)
  • add AI prompting to support this
  • allow client to add this when manually editing

Copy link

qa-wolf bot commented Oct 5, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Oct 5, 2025
@davidfig davidfig self-assigned this Oct 5, 2025
Copy link
Contributor

github-actions bot commented Oct 5, 2025

Preview - Build, Deploy & Tests-E2E

✅ Build images
✅ Deploy images - Oct 09, 2025 at 03:24 PM UTC - Preview
❌ Tests-E2E - Report

@github-actions github-actions bot temporarily deployed to preview-pr-3506 October 5, 2025 15:11 Destroyed
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.78%. Comparing base (c39119c) to head (3aa3e7e).

Files with missing lines Patch % Lines
...rc/controller/execution/run_code/run_connection.rs 90.56% 5 Missing ⚠️
quadratic-core/src/a1/a1_selection/query.rs 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #3506      +/-   ##
==========================================
+ Coverage   89.77%   89.78%   +0.01%     
==========================================
  Files         437      437              
  Lines       90242    90342     +100     
==========================================
+ Hits        81012    81113     +101     
+ Misses       9230     9229       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to preview-pr-3506 October 5, 2025 15:46 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-3506 October 5, 2025 15:57 Destroyed
Copy link
Collaborator

@ddimaria ddimaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits/comments.

@luke-quadratic luke-quadratic reopened this Oct 7, 2025
@github-actions github-actions bot temporarily deployed to preview-pr-3506 October 7, 2025 15:57 Destroyed
@luke-quadratic luke-quadratic self-requested a review October 7, 2025 18:13
Copy link
Contributor

@luke-quadratic luke-quadratic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address why AI is failing every request in this PR.

@davidkircos davidkircos removed the QA label Oct 8, 2025
@github-actions github-actions bot temporarily deployed to preview-pr-3506 October 8, 2025 22:29 Destroyed
@luke-quadratic luke-quadratic reopened this Oct 9, 2025
@github-actions github-actions bot temporarily deployed to preview-pr-3506 October 9, 2025 00:43 Destroyed
@luke-quadratic
Copy link
Contributor

This works, I think I have limited confidence in users' to understand this though:
WHERE type = ANY(string_to_array('{{A2:A4}}', ','))

And AI isn't doing so great with figuring it out. Game to merge this, just feels like limited use if users can't just say WHERE type = {{A2:A4}}

@github-actions github-actions bot temporarily deployed to preview-pr-3506 October 9, 2025 12:56 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-3506 October 9, 2025 14:14 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants