-
Notifications
You must be signed in to change notification settings - Fork 249
Adds a 1d query option for sql #3506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: qa
Are you sure you want to change the base?
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## qa #3506 +/- ##
==========================================
+ Coverage 89.77% 89.78% +0.01%
==========================================
Files 437 437
Lines 90242 90342 +100
==========================================
+ Hits 81012 81113 +101
+ Misses 9230 9229 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quadratic-core/src/controller/execution/run_code/run_connection.rs
Outdated
Show resolved
Hide resolved
quadratic-core/src/controller/execution/run_code/run_connection.rs
Outdated
Show resolved
Hide resolved
quadratic-core/src/controller/execution/run_code/run_connection.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits/comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address why AI is failing every request in this PR.
This works, I think I have limited confidence in users' to understand this though: And AI isn't doing so great with figuring it out. Game to merge this, just feels like limited use if users can't just say WHERE type = {{A2:A4}} |
This adds a 1d query option for connections. Note: this is a naked list of values separated by commas. The user will have to provide quotes or other means of parsing this list in the SQL query. I've added this information to the AI prompting.