Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/quads_client/commands/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@ def cmd_add_quads_server(self, args):
self.shell.poutput("Server not added")
return

# Add server to config
is_first_server = len(config_data["servers"]) == 0

config_data["servers"][server_name] = {
"url": server_url,
"username": username,
Expand All @@ -241,6 +242,9 @@ def cmd_add_quads_server(self, args):
"verify": verify,
}

if is_first_server:
config_data["default_server"] = server_name

try:
with open(config_path, "w") as f:
yaml.dump(config_data, f, default_flow_style=False, sort_keys=False)
Expand Down
25 changes: 24 additions & 1 deletion tests/test_commands_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -343,13 +343,36 @@ def test_add_quads_server_success(mock_shell):
server_cmd.cmd_add_quads_server("")

mock_dump.assert_called_once()
# Verify empty credentials were set
call_args = mock_dump.call_args[0][0]
assert call_args["servers"]["quads3.example.com"]["username"] == ""
assert call_args["servers"]["quads3.example.com"]["password"] == ""
assert call_args["default_server"] == "quads3.example.com"
assert mock_shell.poutput.call_count >= 2


def test_add_quads_server_second_server_no_default_change(mock_shell):
"""Test add-quads-server does not overwrite default_server when servers exist"""
mock_shell.config.config_path = "~/.config/quads/quads-client.yml"

yaml_content = {
"servers": {"existing.example.com": {"url": "https://existing.example.com"}},
"default_server": "existing.example.com",
}

with patch("builtins.input", side_effect=["quads4.example.com", "https://quads4.example.com", "y", "3"]):
with patch("requests.get") as mock_get:
mock_get.return_value.status_code = 200
with patch("builtins.open", mock_open(read_data="servers: {}\n")):
with patch("yaml.safe_load", return_value=yaml_content):
with patch("yaml.dump") as mock_dump:
with patch.object(ServerCommands, "cmd_config_reload"):
server_cmd = ServerCommands(mock_shell)
server_cmd.cmd_add_quads_server("")

call_args = mock_dump.call_args[0][0]
assert call_args["default_server"] == "existing.example.com"


def test_add_quads_server_empty_name(mock_shell):
"""Test add-quads-server with empty server name"""
with patch("builtins.input", return_value=""):
Expand Down
Loading