Conversation
|
I based it on top of #31 which should be merged first. |
|
|
||
| {% block auto_login_commands %} | ||
| login_commands: | ||
| - "debian" |
There was a problem hiding this comment.
FYI, this might get stepped on by qualcomm-linux/qcom-deb-images#316
There was a problem hiding this comment.
I guess you should send a patch when you expect it to be merged.
lool
left a comment
There was a problem hiding this comment.
Unrelated to your PR, but FYI there's a typo in the filename: lava_test_plans/testcases/pre-merge-dispaly-gfx.yaml (dispaly instead of display)
Left a few other comments from a quick pass on the changes
|
|
||
| {% block test_target %} | ||
| {% for test in all_tests %} | ||
| {% if (test.name not in EXCLUDED_TESTS) and (test.include|default(true)) %} |
There was a problem hiding this comment.
Not sure why all_tests is lowercased, and EXCLUDED_TESTS is uppercased
There was a problem hiding this comment.
Uppercase variables can be overwritten from user input. Lower case variables are internal to the tool.
| {% extends "devices/qcs615-ride" %} No newline at end of file | ||
| {% extends "devices/qcs615-ride" %} | ||
|
|
||
| {% set EXCLUDED_TESTS = ['BT_FW_KMD_Service', 'BT_SCAN'] %} |
There was a problem hiding this comment.
These changes seem unrelated to Debian support
There was a problem hiding this comment.
BT doesn't work on qcs615 devices we have in the LAB. I can remove it, but then BT tests that are included in the pre-merge set will fail.
There was a problem hiding this comment.
I see; I guess this could be indicative of these changes belonging into a separate PR
There was a problem hiding this comment.
I'll move it to a separate commit.
lava_test_plans/__main__.py
Outdated
| def _submit_to_lava(lava_job, lava_url_base, lava_username, lava_token): | ||
| if not ( | ||
| lava_url_base.startswith("http://") | ||
| or lava_url_base.startswith("https://") |
There was a problem hiding this comment.
This should be squashed into the earlier commit that makes these changes
| {% set PROJECT = PROJECT|default("") %} | ||
| {% extends PROJECT+"flasher.jinja2" %} | ||
|
|
||
| {% set BOOT_OS_PROMPT = BOOT_OS_PROMPT|default("root@iq-8075-evk") %} |
There was a problem hiding this comment.
Yocto uses machine-specific prompts, but qcom-deb-images does not; right now, it's always debian@debian; we'd like to change this in the future (Ubuntu support, device-specific hostnames), but for now I think you should hardcode debian@debian for qcom-deb-images.
This is a common file though; perhaps this should be an OS specific template instead, with a meta-qcom version and a qcom-deb-images version.
There was a problem hiding this comment.
ACK. I can move it one level up - project setting, not a device-in-a-project setting
|
|
||
| {% set rootfs_label = 'rootfs' %} | ||
|
|
||
| {% set FLASHER_DEVICE_TYPE = "debian-monaco-arduino-monza_emmc" %} |
There was a problem hiding this comment.
Could we avoid requiring a per-device template file? They are all following the same naming convention and structure
There was a problem hiding this comment.
I'm not so sure. There is qrb2210-arduino-imola but monaco-arduino-monza. It should be either agatti-arduino-imola or qcs8300-arduino-monza. On top of that device specific files are used to exclude tests and amend flashing instructions.
|
|
||
| {% block auto_login_commands %} | ||
| login_commands: | ||
| - "debian" |
There was a problem hiding this comment.
I was expecting:
- debian
- debian
- debian
- new password
- new password
The first two being login + password, the third one being password again before changing password, and the new password lines being the one + confirmation.
There was a problem hiding this comment.
login+password (initial login) is handled by auto_login section. So this part only takes care of changing the password on 1st login.
a6a95e1 to
11a9999
Compare
Add required postprocess steps and boot commands in debian templates Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Add project specific details for flasher deployment in qcom-deb-images Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Add links to common testcases to be used as qcom-deb-images test plans. The structure of the test plans is similar to meta-qcom with 2 test plans available: - boot - pre-merge Pre-merge test plan contains several job templates exercising different features Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Add devices that are specific to qcom-deb-images. The {% extends %}
block maps them to existing common devices. If there is no such device,
full config is stored in the project specific device
Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Fix name of pre-merge-display-gfx.yaml (was pre-merge-dispaly-gfx.yaml) and update the links in project specific test plans. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
11a9999 to
b8f7021
Compare
Thanks. This is now fixed. |
Add support for qcom-deb-images project: