Skip to content

Debian support#30

Open
mwasilew wants to merge 6 commits intoqualcomm-linux:masterfrom
mwasilew:debian-support
Open

Debian support#30
mwasilew wants to merge 6 commits intoqualcomm-linux:masterfrom
mwasilew:debian-support

Conversation

@mwasilew
Copy link
Copy Markdown

@mwasilew mwasilew commented Mar 6, 2026

Add support for qcom-deb-images project:

  • define project specific devices
  • change the flashing procedure for debian images
  • add test plans for qcom-deb-images

@mwasilew
Copy link
Copy Markdown
Author

mwasilew commented Mar 9, 2026

I based it on top of #31 which should be merged first.


{% block auto_login_commands %}
login_commands:
- "debian"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this might get stepped on by qualcomm-linux/qcom-deb-images#316

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you should send a patch when you expect it to be merged.

Copy link
Copy Markdown

@lool lool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to your PR, but FYI there's a typo in the filename: lava_test_plans/testcases/pre-merge-dispaly-gfx.yaml (dispaly instead of display)

Left a few other comments from a quick pass on the changes


{% block test_target %}
{% for test in all_tests %}
{% if (test.name not in EXCLUDED_TESTS) and (test.include|default(true)) %}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why all_tests is lowercased, and EXCLUDED_TESTS is uppercased

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppercase variables can be overwritten from user input. Lower case variables are internal to the tool.

{% extends "devices/qcs615-ride" %} No newline at end of file
{% extends "devices/qcs615-ride" %}

{% set EXCLUDED_TESTS = ['BT_FW_KMD_Service', 'BT_SCAN'] %}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem unrelated to Debian support

Copy link
Copy Markdown
Author

@mwasilew mwasilew Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BT doesn't work on qcs615 devices we have in the LAB. I can remove it, but then BT tests that are included in the pre-merge set will fail.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see; I guess this could be indicative of these changes belonging into a separate PR

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move it to a separate commit.

def _submit_to_lava(lava_job, lava_url_base, lava_username, lava_token):
if not (
lava_url_base.startswith("http://")
or lava_url_base.startswith("https://")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be squashed into the earlier commit that makes these changes

{% set PROJECT = PROJECT|default("") %}
{% extends PROJECT+"flasher.jinja2" %}

{% set BOOT_OS_PROMPT = BOOT_OS_PROMPT|default("root@iq-8075-evk") %}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yocto uses machine-specific prompts, but qcom-deb-images does not; right now, it's always debian@debian; we'd like to change this in the future (Ubuntu support, device-specific hostnames), but for now I think you should hardcode debian@debian for qcom-deb-images.

This is a common file though; perhaps this should be an OS specific template instead, with a meta-qcom version and a qcom-deb-images version.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I can move it one level up - project setting, not a device-in-a-project setting


{% set rootfs_label = 'rootfs' %}

{% set FLASHER_DEVICE_TYPE = "debian-monaco-arduino-monza_emmc" %}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we avoid requiring a per-device template file? They are all following the same naming convention and structure

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure. There is qrb2210-arduino-imola but monaco-arduino-monza. It should be either agatti-arduino-imola or qcs8300-arduino-monza. On top of that device specific files are used to exclude tests and amend flashing instructions.


{% block auto_login_commands %}
login_commands:
- "debian"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting:

  • debian
  • debian
  • debian
  • new password
  • new password

The first two being login + password, the third one being password again before changing password, and the new password lines being the one + confirmation.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login+password (initial login) is handled by auto_login section. So this part only takes care of changing the password on 1st login.

Add required postprocess steps and boot commands in debian templates

Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Add project specific details for flasher deployment in qcom-deb-images

Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Add links to common testcases to be used as qcom-deb-images test plans.
The structure of the test plans is similar to meta-qcom with 2 test
plans available:
 - boot
 - pre-merge

Pre-merge test plan contains several job templates exercising different
features

Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Add devices that are specific to qcom-deb-images. The {% extends %}
block maps them to existing common devices. If there is no such device,
full config is stored in the project specific device

Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Fix name of pre-merge-display-gfx.yaml (was pre-merge-dispaly-gfx.yaml)
and update the links in project specific test plans.

Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
@mwasilew
Copy link
Copy Markdown
Author

Unrelated to your PR, but FYI there's a typo in the filename: lava_test_plans/testcases/pre-merge-dispaly-gfx.yaml (dispaly instead of display)

Thanks. This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants