Skip to content

Makefile: allow to override fakemachine options#327

Merged
lool merged 1 commit intoqualcomm-linux:mainfrom
gagath:makefile-support-disable-fakemachine
Mar 17, 2026
Merged

Makefile: allow to override fakemachine options#327
lool merged 1 commit intoqualcomm-linux:mainfrom
gagath:makefile-support-disable-fakemachine

Conversation

@gagath
Copy link
Copy Markdown
Contributor

@gagath gagath commented Mar 16, 2026 •
edited
Loading

Allow to override fakemachine opts manually when needed.

Closes: #326

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026 •
edited
Loading

Test Results

 2 files  ±0   6 suites  ±0   3m 23s ⏱️ ±0s
20 tests ±0  20 ✅ ±0  0 💤 ±0  0 ❌ ±0 
64 runs  ±0  64 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 816f039. ± Comparison against base commit 63c8215.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

Test jobs for commit 69154c1

@gagath gagath mentioned this pull request Mar 16, 2026
Merged
lool
lool requested changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lool lool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates autodetection logic in debos to select kvm automatically.

This also creates a mirror copy of very specific debos options in the Makefile (fakemachine is a very debos thing), which can also be passed as EXTRA_DEBOS_OPTIONS = --disable-fakemachine

So I really don't like this idea; -1 for me (sorry!)

Also, I don't think running debos without fakemachine is recommended, both for impact on the host and for reproducibility of the images, so I don't want to promote this practice either.

@gagath gagath force-pushed the makefile-support-disable-fakemachine branch from 69154c1 to 816f039 Compare March 17, 2026 09:36
@gagath
Copy link
Copy Markdown
Contributor Author

gagath commented Mar 17, 2026 •
edited
Loading

As explained in #326 passing the EXTRA_DEBOS_OPTS=--disable-fakemachine does not work as it is exclusive with the already set --fakemachine-backend. I have pushed a more versatile revision that introduces FAKEMACHINE_OPTS so that it can be overridden when needed.

@gagath gagath changed the title Makefile: allow to disable fakemachine Makefile: allow to override fakemachine options Mar 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 17, 2026

Test jobs for commit 816f039

lool
lool approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lool lool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description before merging

@lool
Copy link
Copy Markdown
Contributor

lool commented Mar 17, 2026

Could you rebase?

@gagath
feat(Makefile): allow to override FAKEMACHINE_OPTS
60486e9 
Closes: qualcomm-linux#326

Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
@gagath gagath force-pushed the makefile-support-disable-fakemachine branch from 816f039 to 60486e9 Compare March 17, 2026 16:44
@gagath
Copy link
Copy Markdown
Contributor Author

gagath commented Mar 17, 2026

Updated description and rebased on top of main.

@lool lool merged commit bb24abd into qualcomm-linux:main Mar 17, 2026
12 checks passed
@gagath gagath deleted the makefile-support-disable-fakemachine branch March 17, 2026 17:08
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 17, 2026

Test jobs for commit 60486e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lool lool lool approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Makefile does not allow to disable fakemachine

2 participants

@gagath @lool