feat(Makefile): add flash_glymur/ target#331
Closed
gagath wants to merge 1 commit intoqualcomm-linux:mainfrom
Closed
feat(Makefile): add flash_glymur/ target#331gagath wants to merge 1 commit intoqualcomm-linux:mainfrom
gagath wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
Add a new target that downloads the Glymur firmware and extracts it in a flash_glymur/ directory. This allows for autocompletion thanks to Makefile targets and allows to do the following and get what one would expect: $ make flash_glymur/bootfw1.bin $ # or simply: $ make flash_glymur/ Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
gagath
force-pushed
the
glymur-bootbinaries
branch
from
11f28b2 to
d7c9f87
Compare
lool
requested changes
Mar 18, 2026
Contributor
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
It's great to see efforts to bring in boot binaries for Glymur.
We don't want to have two ways of creating flashable images. The debos flash recipe is probably hard to parse and could benefit from some refactoring, but glymur-crd support should land in common code.
I'd also love the Makefile to support generating flashable assets, but not in a completely different way.
Other notable things:
- new curl dependency
- flash_glymur is named after silicon family instead of board name + storage backend
- flash_glymur doesn't contain *.xml files for flashing
Test jobs for commit 11f28b2 |
Test jobs for commit d7c9f87 |
Contributor
Author
|
Superseded by #332. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new target that downloads the Glymur firmware and extracts it in a flash_glymur/ directory. This allows for autocompletion thanks to Makefile targets and allows to do the following and get what one would expect: