feat(flash): add glymur-crd spinor platform support#338
Merged
lool merged 1 commit intoqualcomm-linux:mainfrom Mar 26, 2026
Merged
feat(flash): add glymur-crd spinor platform support#338lool merged 1 commit intoqualcomm-linux:mainfrom
lool merged 1 commit intoqualcomm-linux:mainfrom
Conversation
Add glymur-crd/spinor as a second ptool platform for glymur-crd. Add spinor disk type to the case statement with empty esp/rootfs since spinor carries firmware partitions only (no OS efi/rootfs). The nvme flash directory will still receive all boot binaries (including firmware) for now; this can be refined in a follow-up. Signed-off-by: Adam Bickett <abickett@qti.qualcomm.com>
gagath
approved these changes
Mar 26, 2026
Contributor
|
I can confirm flashing works when removing dtb_b partition manually from the XML file. This step is still manual, but can be done on the user side instead of us crafting some way to remove the line while it is fixed. Merging this will allow to have spinor support in the daily Glymur builds. |
Test jobs for commit ac4213c |
lool
approved these changes
Mar 26, 2026
Contributor
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
I've discussed this implementation strategy with Adam, this is keeping in mind:
- I've submitted invasive changes to ptool to support multi-disk / multi storage configs
- we want to rewrite the gist of the flash recipe in Python
This shorter implementation by Adam is easy enough, and its only immediate drawback is that a number of extra files are present (dtb.bin and CDT are present in both spinor and nvme subdirs, but only referred to from the spinor XML flashing files).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds spinor support. This is a temporary enablement while full dual-storage support is in development (qualcomm-linux/qcom-ptool#86) .
Testing on device showed a failure to flash the populated spinor dtb_b partition. It appears that this is beyond range
partitions.conf reports size=67108864 but dtb_b is over this - will need to be fixed
qualcomm-linux/qcom-ptool@b7c75db
Flashing succeeds when removing dtb.bin / dtb_b entry
Add glymur-crd/spinor as a second ptool platform for glymur-crd. Add spinor disk type to the case statement with empty esp/rootfs since spinor carries firmware partitions only (no OS efi/rootfs).
The nvme flash directory will still receive all boot binaries (including firmware) for now; this can be refined in a follow-up.