Conversation
|
One shortcoming is that the flash target depends on both UFS and sdcard images as we do not have a clear way to determine what we need for the target hardware. The dependency can be removed if we want to rely on users to generate the proper image themselves to win build time, but at the cost of more manual steps (for now). This is needed either way to allow docker users to generate the flash artifacts. |
Makefile
Outdated
| $(DEBOS_CMD) -t imagetype:sdcard $< | ||
|
|
||
| .PHONY: flash | ||
| flash: debos-recipes/qualcomm-linux-debian-flash.yaml dtbs.tar.gz disk-sdcard.img1 disk-ufs.img1 |
There was a problem hiding this comment.
in practice, one doesn't need disk-sdcard and disk-ufs to build the flash assets, and I find it convenient to run the flash recipe with just dtbs.tar.gz around when working on that part of the recipes. Is there a way we could reconcile both goals of:
- using make to build everything up to flash images
- using make to build just the flash assets
Perhaps two targets?
There was a problem hiding this comment.
I agree that only dtbs.tar.gz in needed to run the recipe as the images are required when flashing and not generating the files. I will just drop the image dependency as I was not happy with it in the first place either and only keep the dtb dependency.
The *.img1 and *.img2 intermediate files are produced by the image recipe but currently not properly tracked in the Makefile. Add proper targets so that other recipes like the flash recipe can depend on img1 and have them generated if missing or accidentally removed. Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
Track which recipe produces the dtbs.tar.gz artefact for consumption by other targets. Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
Introduce a new target that depends on previous artefacts to generate call the flash recipe with proper arguments and docker support. Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
gagath
force-pushed
the
makefile-flash-target
branch
from
58decc0 to
238297b
Compare
Test jobs for commit 58decc0 |
Test jobs for commit 238297b |
|
Can we change the github workflow to call this? |
|
2 participants
Thanks to @abickett for the idea, this should allow Docker support for calling the flash recipe. README is updated to use the new target.