Skip to content

feat(debos.yml): add unknown platforms to flash-emmc.tar.gz#340

Merged
lool merged 1 commit intoqualcomm-linux:mainfrom
gagath:flash-nvme-ci
Mar 26, 2026
Merged

feat(debos.yml): add unknown platforms to flash-emmc.tar.gz#340
lool merged 1 commit intoqualcomm-linux:mainfrom
gagath:flash-nvme-ci

Conversation

@gagath
Copy link
Copy Markdown
Contributor

@gagath gagath commented Mar 26, 2026

With the newly introduced NVME support we want the CI to be able to ship the generated files to users through a new flash-nvme.tar.gz artifact.

@gagath gagath requested a review from lool March 26, 2026 09:03
@gagath
Copy link
Copy Markdown
Contributor Author

gagath commented Mar 26, 2026

Note that something similiar is probably needed for spinor as well, but I am not sure if we want to deliver it too as it is in early state and has its issues (eg. dtb_b).

Copy link
Copy Markdown
Contributor

@lool lool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The reason we have flash-ufs and flash-emmc is because a flash-all would be twice as big, including 512B and 4k sectors versions of the rootfs and ESP.

This change would make our daily artifacts ~50% larger.

I think we need to fix this by renaming the artifacts to a clearer technical name, and provide userfriendly guidelines through docs. We can fix the artifacts name in a separate PR.

These artifacts should go with other flash assets that use disk-sdcard.

  1. nvme might support 4k sectors too; i fact, I was told multiple times Glymur CRD boot firmware should be used with a 4k sector ESP. I realize now it was a bit naive to make nvme unconditionally use disk-sdcard assets, and I want to fix this somehow.

  2. Another problem I see is with multi storage, we want the spinor and nvme glymur flashable tarballs in the same download somehow. This wouldn't be an issue if we were working with "spinor-nvme" as a target.

Let's find a decent way to include spinor dirs in the emmc or both flash tarballs.

In the past, we had a stamp file in the flash_* subdirs saying which class of storage it was. I guess we can just grep for it though.

Could you:

  • change the workflow to include all dirs that refer to disk-sdcard in flash-emmc, and all dirs that refer to disk-ufs in flash-ufs; if that's too complex to do quickly, just include nvme dirs in flash-emmc
  • include dirs that don't refer to anything, which should be just the glymur spinor build, in the flash-emmc tarball; if that's too complex to do quickly, just include the spinor dirs in flash-emmc

@gagath gagath changed the title feat(debos.yml): add flash-nvme.tar.gz generation feat(debos.yml): add unknown platforms to flash-emmc.tar.gz Mar 26, 2026
@gagath
Copy link
Copy Markdown
Contributor Author

gagath commented Mar 26, 2026

Added a new script that correctly classifies nvme into emmc because of disk-sdcard, and spinor into emmc by default because of no sdcard or ufs found in partitions.conf.

@gagath gagath requested a review from lool March 26, 2026 10:20
Copy link
Copy Markdown
Contributor

@lool lool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, but otherwise happy with this

I would have preferred Python since that's where we'll consolidate, but the shell step is making the review easier right now :)

@lool
Copy link
Copy Markdown
Contributor

lool commented Mar 26, 2026

@gagath Would you mind also confirming how you've tested this locally?

With the newly introduced NVME support we want the CI to be able to ship
the generated files to users through the existing flash-emmc.tar.gz
artefact.

Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
@lool lool merged commit bc5de20 into qualcomm-linux:main Mar 26, 2026
16 checks passed
@gagath
Copy link
Copy Markdown
Contributor Author

gagath commented Mar 26, 2026

@gagath Would you mind also confirming how you've tested this locally?

I run the script and verified the output of the following two lines:

echo "emmc_dirs: $emmc_dirs"
echo "ufs_dirs: $ufs_dirs"

which gives me:

emmc_dirs:  flash_glymur-crd_nvme flash_glymur-crd_spinor flash_monaco-evk_emmc flash_qrb2210-arduino-imola_emmc
ufs_dirs:  flash_lemans-evk_ufs flash_monaco-evk_ufs flash_qcs615-ride_ufs flash_qcs6490-rb3gen2-vision-kit_ufs flash_qcs8300-ride_ufs flash_qcs9100-ride-r3_ufs

that confirms I have glymur nvme and spinor in emmc.

@gagath gagath deleted the flash-nvme-ci branch March 26, 2026 12:46
@lool
Copy link
Copy Markdown
Contributor

lool commented Mar 26, 2026

I've kicked a glymur build here, but I think we should switch it to qcom-next kernel; see #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants