feat(debos.yml): add unknown platforms to flash-emmc.tar.gz#340
feat(debos.yml): add unknown platforms to flash-emmc.tar.gz#340lool merged 1 commit intoqualcomm-linux:mainfrom
Conversation
|
Note that something similiar is probably needed for spinor as well, but I am not sure if we want to deliver it too as it is in early state and has its issues (eg. dtb_b). |
lool
left a comment
There was a problem hiding this comment.
- The reason we have flash-ufs and flash-emmc is because a flash-all would be twice as big, including 512B and 4k sectors versions of the rootfs and ESP.
This change would make our daily artifacts ~50% larger.
I think we need to fix this by renaming the artifacts to a clearer technical name, and provide userfriendly guidelines through docs. We can fix the artifacts name in a separate PR.
These artifacts should go with other flash assets that use disk-sdcard.
-
nvme might support 4k sectors too; i fact, I was told multiple times Glymur CRD boot firmware should be used with a 4k sector ESP. I realize now it was a bit naive to make nvme unconditionally use disk-sdcard assets, and I want to fix this somehow.
-
Another problem I see is with multi storage, we want the spinor and nvme glymur flashable tarballs in the same download somehow. This wouldn't be an issue if we were working with "spinor-nvme" as a target.
Let's find a decent way to include spinor dirs in the emmc or both flash tarballs.
In the past, we had a stamp file in the flash_* subdirs saying which class of storage it was. I guess we can just grep for it though.
Could you:
- change the workflow to include all dirs that refer to disk-sdcard in flash-emmc, and all dirs that refer to disk-ufs in flash-ufs; if that's too complex to do quickly, just include nvme dirs in flash-emmc
- include dirs that don't refer to anything, which should be just the glymur spinor build, in the flash-emmc tarball; if that's too complex to do quickly, just include the spinor dirs in flash-emmc
|
Added a new script that correctly classifies nvme into emmc because of disk-sdcard, and spinor into emmc by default because of no sdcard or ufs found in partitions.conf. |
lool
left a comment
There was a problem hiding this comment.
Minor nits, but otherwise happy with this
I would have preferred Python since that's where we'll consolidate, but the shell step is making the review easier right now :)
|
@gagath Would you mind also confirming how you've tested this locally? |
With the newly introduced NVME support we want the CI to be able to ship the generated files to users through the existing flash-emmc.tar.gz artefact. Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
I run the script and verified the output of the following two lines: which gives me: that confirms I have glymur nvme and spinor in emmc. |
With the newly introduced NVME support we want the CI to be able to ship the generated files to users through a new flash-nvme.tar.gz artifact.