Conversation
Using systemd-ukify, create a UKI .efi file that can be booted directly, bypassing systemd-boot. Both exists after this commit, and the UKI can be booted successfully from QEMU's "boot from file" option in BIOS. Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
Add dtauto support in the generated UKI for a subset of selected qcom hardware. Stubble allows to select the correct DTB based on the hardware and pass it to the kernel. Closes: qualcomm-linux#227 Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
Cool! Left a few comments
I don't think we're in a rush to land this until we have figured where to do things correctly (otherwise we'll be distracted and will keep the technical debt); we could develop changes to systemd of ukify or kernel-install if needed
| recommends: true | ||
| packages: | ||
| # provides objdump | ||
| - binutils |
There was a problem hiding this comment.
Hmm I like the idea of testing it somehow, but I don't like doing it at image generation time
I expect UKI to be generated on kernel install / upgrade, so they likely belong in an autopkgtest related to that, perhaps systemd-boot; we can contribute that in Debian?
There was a problem hiding this comment.
This is to verify the content of our generated image. Autopkgtests are used to test packages themselves and fit a different purpose. Do you want me to remove tests that verify the content of our image?
There was a problem hiding this comment.
autopkgtests are used for integration testing; I think this test primarily belongs to the integration tests of the specific UKI generation you're writing, rather than to image tests
| dt_auto="" | ||
| for image in /lib/linux-image-* | ||
| do | ||
| for dtb in "${image}"/qcom/x1e78100* |
There was a problem hiding this comment.
Can we include all DTBs from stubble-data somehow?
| tee /etc/kernel/uki.conf <<EOF | ||
| [UKI] | ||
| HWIDs=/usr/share/stubble/hwids/ | ||
| DeviceTreeAuto=$dt_auto |
There was a problem hiding this comment.
this will get out of date, how about we add a kernel install script that updates this line in the file with a comment that the line is automatically updated? these two could be provided by some stubble package in Debian?
Test jobs for commit cd75233 |
2 participants
This is a proposal for a first basic support of UKIs with stubble and DeviceTreeAuto support.