Skip to content

fix(get-rawprogram-filename): Return none when missing#370

Merged
lool merged 1 commit intoqualcomm-linux:mainfrom
vishwasudupa:bugfix-getrawprogram
Apr 17, 2026
Merged

fix(get-rawprogram-filename): Return none when missing#370
lool merged 1 commit intoqualcomm-linux:mainfrom
vishwasudupa:bugfix-getrawprogram

Conversation

@vishwasudupa
Copy link
Copy Markdown
Contributor

@vishwasudupa vishwasudupa commented Apr 17, 2026

Return none when the input XML does not contain a rootfs entry or
when parsing fails, instead of erroring out. This allows callers to
distinguish between valid matches and missing data gracefully.

@vishwasudupa
Copy link
Copy Markdown
Contributor Author

Return None when the input XML does not contain a rootfs entry or when parsing fails, instead of erroring out. This allows script to exit gracefully.

this would help to fix regression caused in latest nightly build

@github-actions
Copy link
Copy Markdown

Test Results

 2 files  ±0   6 suites  ±0   3m 59s ⏱️ ±0s
20 tests ±0  20 ✅ ±0  0 💤 ±0  0 ❌ ±0 
64 runs  ±0  64 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4530788. ± Comparison against base commit c45e2ae.

@github-actions
Copy link
Copy Markdown

Test jobs for commit 4530788

@lool
Copy link
Copy Markdown
Contributor

lool commented Apr 17, 2026

@copilot review this

Return none when the input XML does not contain a rootfs entry or
when parsing fails, instead of erroring out. This allows callers to
distinguish between valid matches and missing data gracefully.

Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
@lool lool force-pushed the bugfix-getrawprogram branch from 4530788 to 2bef6a5 Compare April 17, 2026 12:14
@lool lool changed the title fix(scripts/get-rawprogram): in case of error, return gracefully fix(get-rawprogram-filename): Return none when missing Apr 17, 2026
@lool lool merged commit f9ecc0e into qualcomm-linux:main Apr 17, 2026
16 checks passed
@github-actions
Copy link
Copy Markdown

Test jobs for commit 2bef6a5

@nivasnaik
Copy link
Copy Markdown

@copilot review this

Copilot did not highlight this tough :)

@lool
Copy link
Copy Markdown
Contributor

lool commented Apr 17, 2026

@copilot review this

Copilot did not highlight this tough :)

I keep trying from time to time, hoping we'll fix it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants