[cpullvm] upgrade ram size for riscv variants#375
Merged
Conversation
Contributor
Author
|
related #374 |
Contributor
|
Can you include a mention in the commit message/PR description about where the new size is coming from (is it just a value that was large enough experimentally for the tests in question?) would be helpful. |
Contributor
Author
|
@jonathonpenix I've updated the description with a reference to where the sizes come from. |
Contributor
|
@bojle, can you add the information about how you adjusted the sizes to the commit message? It is helpful for future maintainers. @quic-garvgupt will do a combo run with his additional patches to confirm the issues are resolved. |
Tests such as dynamic_cast14.pass.cpp in libcxxabi fail due to infsufficient RAM size. This patch fixes it by increasing the RAM size allocated to qemu. Tests such as dynamic_cast14.pass.cpp in libcxxabi fail due to infsufficient RAM size. This patch fixes it by increasing the RAM size allocated to qemu. The sizes are derived from the reports of failed test cases empirically. dynamic_cast14 overflows by 7.7MB, its executable size is 2MB, which implies a requirement of ~9.5MB. Therefore, a size of 10MB is chosen for all riscv variants. Other tests, as they're uncovered may demand a higher size, in which case this can be adjusted. Signed-off-by: Shreeyash Pandey <shrpand@qti.qualcomm.com>
Contributor
Author
|
Added the method of deciding on the ram size to the commit message and the PR description. @apazos please check it out. |
apazos
approved these changes
Jun 3, 2026
jonathonpenix
approved these changes
Jun 3, 2026
apazos
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests such as dynamic_cast14.pass.cpp in libcxxabi fail due to
infsufficient RAM size. This patch fixes it by increasing the RAM size
allocated to qemu.
Tests such as dynamic_cast14.pass.cpp in libcxxabi fail due to
infsufficient RAM size. This patch fixes it by increasing the RAM size
allocated to qemu. The sizes are derived from the reports of failed test
cases empirically. dynamic_cast14 overflows by 7.7MB, its executable
size is 2MB, which implies a requirement of ~9.5MB. Therefore, a size
of 10MB is chosen for all riscv variants. Other tests, as they're
uncovered may demand a higher size, in which case this can be adjusted.