Ignore hid import when it's not required#4
Merged
Conversation
hid module is only required for Bughopper v2 board. This patch makes the hid import optional and allows pytac to work without hid and it's dependencies when using other debug boards. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Contributor
|
What about requirements.txt? If a user installs dependencies from there ignoring hid lib is not useful. I suppose most of the users would install dependencies from there. |
SuMere
approved these changes
Jun 9, 2026
Contributor
Author
The problem is that installing python module doesn't force dependencies installation. For |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hid module is only required for Bughopper v2 board. This patch makes the hid import optional and allows pytac to work without hid and it's dependencies when using other debug boards.