standalone_systests: drop hardcoded CWD path check in semihost#34
Merged
Merged
Conversation
The semihost test asserted that GETCWD returns a path ending in "tests/tcg/hexagon-softmmu" -- a holdover from when the test was run from the QEMU source tree by the TCG harness. After moving the test to QEMU's functional-test framework, the binary runs from a per-test workdir and the suffix check fails for no good reason. The check was a sanity check on where the test ran, not a validation of GETCWD itself; remove it. The remaining assert on `ret` still verifies that GETCWD succeeded. Remove the now-unused `path_ends_with` helper and its `is_path_sep` macro along with it. Signed-off-by: Marco Liebel <marco.liebel@oss.qualcomm.com>
androm3da
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semihost test asserted that GETCWD returns a path ending in "tests/tcg/hexagon-softmmu" -- a holdover from when the test was run from the QEMU source tree by the TCG harness. After moving the test to QEMU's functional-test framework, the binary runs from a per-test workdir and the suffix check fails for no good reason.
The check was a sanity check on where the test ran, not a validation of GETCWD itself; remove it. The remaining assert on
retstill verifies that GETCWD succeeded.Remove the now-unused
path_ends_withhelper and itsis_path_sepmacro along with it.