chore/oxlint#290
Merged
Merged
Conversation
Ryan Bower (R-Bower)
force-pushed
the
chore/oxlint
branch
5 times, most recently
from
f6f48b4 to
67f48be
Compare
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Ryan Bower (R-Bower)
force-pushed
the
chore/oxlint
branch
from
f50c121 to
0827862
Compare
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
…ain config - merged performance config into styleGuide and recommended configs - enabled eslint and promise rules for parity with default oxlint - `recommended` now exports a single flat config object instead of an array. Consumers should update usages from: ```js extends: [...quiEslintTs.configs.recommended] ``` to: ```js extends: [quiEslintTs.configs.recommended] ``` This keeps the same recommended TypeScript rules while matching the config shape used by the other ESLint config packages. Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Ryan Bower (R-Bower)
force-pushed
the
chore/oxlint
branch
from
4b4b734 to
bc5ac76
Compare
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Ryan Bower (R-Bower)
force-pushed
the
chore/oxlint
branch
from
bc5ac76 to
57462e0
Compare
The base config has been moved into each config. Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Ryan Bower (R-Bower)
force-pushed
the
chore/oxlint
branch
from
98a66f3 to
79c6076
Compare
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Only two configs are exported now: typescriptRecommended and templateRecommended Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
Ryan Bower (R-Bower)
force-pushed
the
chore/oxlint
branch
from
79c6076 to
44fa672
Compare
Signed-off-by: Ryan Bower <rbower@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this PR was originally intended to replace ESLint with Oxlint, the tooling simply isn't ready yet. There are tons of bugs with the oxc intellij and vscode plugins, particularly with pnpm and WSL2. The autofix experience is also subpar. The tooling needs more time in the oven, but I believe it will eventually get there.
Instead of scrapping all the work, I've decided to update our ESLint configs to align with Oxlint and Oxfmt. Prettier has been replaced entirely with
eslint-plugin-oxfmt. I've adjusted the configs to align (mostly) with oxlint defaults, disabling pedantic / irrelevant rules where appropriate.When the time comes to swap to oxlint, it should mostly be a simple config swap + removal of ESLint. Until then, we'll at least have an expanded, modern ruleset for our main configs.
Since this is a breaking change for each of our config packages that relied on prettier, I took the opportunity to clean up the exported configs in alignment with best practices.
closes #114