Make thread pool capacity configurable via YAML#202
Merged
Kartik Nema (kartnema) merged 8 commits intoMar 4, 2026
Conversation
added 6 commits
February 18, 2026 10:15
| UrmSettings::metaConfigs.mPluginCount = (uint32_t)std::stol(resultBuffer); | ||
|
|
||
| if(UrmSettings::metaConfigs.mDesiredThreadCount < 1) { | ||
| TYPELOGV(META_CONFIG_PARSE_FAILURE, "desiredThreadCount must be >= 1, setting to default value (5)"); |
Contributor
There was a problem hiding this comment.
don't need these logs on 181, 186
| static ErrCode preAllocateWorkers() { | ||
| int32_t desiredThreadCapacity = UrmSettings::desiredThreadCount; | ||
| int32_t maxScalingCapacity = UrmSettings::maxScalingCapacity; | ||
| int32_t desiredThreadCapacity = UrmSettings::metaConfigs.mDesiredThreadCount; |
Contributor
There was a problem hiding this comment.
Make these uint32_t and correct indentation
Contributor
|
Tarun Balaji Nidiganti (@tnidigan) can you fix the merge conflict |
Signed-off-by: Tarun Balaji Nidiganti <tnidigan@qti.qualcomm.com>
Kartik Nema (kartnema)
approved these changes
Mar 4, 2026
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
1 similar comment
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes thread pool capacity configurable through YAML properties instead of hardcoded constants, enabling per-system tuning without recompilation.
Changes Made
Utils.h: Added property name constants
UrmSettings.h:
RestuneInit.cpp:
fetchMetaConfigs()