Exit rogue after successful update

[yuval-qf]

Description

Motivation and Context

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📝 Documentation update
• 🎨 Code style/refactoring (no functional changes)
• 🧪 Test updates
• 🔧 Configuration/build changes

Changes Made

Screenshots/Examples (if applicable)

Checklist

• I have read the CONTRIBUTING.md guide
• My code follows the code style of this project (PEP 8, type hints, docstrings)
• I have run uv run black . to format my code
• I have run uv run flake8 . and fixed all issues
• I have run uv run mypy --config-file .mypy.ini . and addressed type checking issues
• I have run uv run bandit -c .bandit.yaml -r . for security checks
• I have added tests that prove my fix is effective or that my feature works
• I have run uv run pytest and all tests pass
• I have manually tested my changes
• I have updated the documentation accordingly
• I have added/updated type hints for new/modified functions
• My changes generate no new warnings
• I have checked my code for security issues
• Any dependent changes have been merged and published

Testing

Test Configuration:

• Python version:
• OS:
• Other relevant details:

Test Steps:
1.
2.
3.

Additional Notes

Related Issues/PRs

• Fixes #
• Related to #
• Depends on #

---

[coderabbitai]

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

• Bug Fixes
  • Improved the update completion flow to gracefully exit when updates succeed.
  • Enhanced error handling for missing update dependencies.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

The update checker's control flow is modified to gracefully exit the application after a successful update rather than continuing execution. The run_update_command() function now returns a boolean indicating success or failure, and a new exit_gracefully() function prints a success message and exits with code 0.

Changes

Cohort / File(s)	Summary
Update Checker Control Flow rogue/common/update_checker.py	run_update_command() return type changed from None to bool, returning True on success and False on failure or missing tools. New exit_gracefully() function added to handle clean exit with success message. _show_update_prompt() now captures the boolean result and calls exit_gracefully() on successful update.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• drorIvry

Poem

🐰✨ A graceful exit, swift and clean,
When updates succeed, the best we've seen,
No lingering paths or endless flow,
Just a happy goodbye and a cheery "let's go!"

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}